Skip to content

Re Deploy "Add shortcuts preferences to User model""#10056

Merged
santicomp2014 merged 2 commits intomainfrom
revert-10054-revert-10038-shortcuts
Feb 9, 2026
Merged

Re Deploy "Add shortcuts preferences to User model""#10056
santicomp2014 merged 2 commits intomainfrom
revert-10054-revert-10038-shortcuts

Conversation

@santicomp2014
Copy link
Copy Markdown
Contributor

@santicomp2014 santicomp2014 commented Feb 9, 2026

This pull request introduces support for storing and managing user keyboard shortcut preferences in the application. The main changes include adding a new JSONB column to the User model, updating the user preferences service to handle and validate shortcut preferences, and extending session and test logic to support and verify this feature.

User shortcut preferences support:

  • Added a shortcuts_preferences JSONB column to the User model for storing user keyboard shortcut preferences, persisting SQL NULL when the value is cleared. (h/models/user.py) [1] [2]
  • Updated the user preferences update logic to accept and validate shortcuts_preferences, including checks for allowed actions, value types, and duplicate shortcut values, with support for repeatable shortcut groups. (h/services/user.py) [1] [2]

Session and preferences integration:

  • Modified session logic to include shortcuts_preferences in user preferences when set, and omit it when unset. (h/session.py)

Testing and validation:

  • Added and expanded unit tests for the User model, user preference service, and session logic to verify correct handling, persistence, and validation of shortcuts_preferences. (tests/unit/h/models/user_test.py, tests/unit/h/services/user_test.py, tests/unit/h/session_test.py) [1] [2] [3] [4]

@santicomp2014 santicomp2014 self-assigned this Feb 9, 2026
@santicomp2014 santicomp2014 merged commit f4a572c into main Feb 9, 2026
10 checks passed
@santicomp2014 santicomp2014 deleted the revert-10054-revert-10038-shortcuts branch February 9, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants