Re Deploy "Add shortcuts preferences to User model""#10056
Merged
santicomp2014 merged 2 commits intomainfrom Feb 9, 2026
Merged
Re Deploy "Add shortcuts preferences to User model""#10056santicomp2014 merged 2 commits intomainfrom
santicomp2014 merged 2 commits intomainfrom
Conversation
karenrasmussen
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for storing and managing user keyboard shortcut preferences in the application. The main changes include adding a new JSONB column to the
Usermodel, updating the user preferences service to handle and validate shortcut preferences, and extending session and test logic to support and verify this feature.User shortcut preferences support:
shortcuts_preferencesJSONB column to theUsermodel for storing user keyboard shortcut preferences, persisting SQL NULL when the value is cleared. (h/models/user.py) [1] [2]shortcuts_preferences, including checks for allowed actions, value types, and duplicate shortcut values, with support for repeatable shortcut groups. (h/services/user.py) [1] [2]Session and preferences integration:
shortcuts_preferencesin user preferences when set, and omit it when unset. (h/session.py)Testing and validation:
Usermodel, user preference service, and session logic to verify correct handling, persistence, and validation ofshortcuts_preferences. (tests/unit/h/models/user_test.py,tests/unit/h/services/user_test.py,tests/unit/h/session_test.py) [1] [2] [3] [4]