Thread collapsing redux #2349

merged 4 commits into from Jul 7, 2015


None yet

3 participants


This reintroduces the thread collapsing improvements as described in #2337.

It appears that commit cdddb16 broke thread collapsing by hiding the bodies of top level annotations. This has been fixed by a small adjustment to annotations.scss.


Code Health
Code quality remained the same when pulling 5653095 on hypothesis:thread-collapsing-redux into 561544e on hypothesis:master.

JakeHartnell and others added some commits Jul 6, 2015
@JakeHartnell @tilgovi JakeHartnell Fix thread collapsing UX. bc6ca26
@tilgovi tilgovi Clean up use of footer and body sections
Make the tags section use .annotation-body (because tags are a form of
body) and put the form actions, reply count, and license messages into
the footer so that these collpasing properly and uniformly.
@tilgovi tilgovi Show a sign in message in unsaved annotations
Since there is no username, collapsing a draft when not signed in
had been causing the annotation to disappear completely. Now, there
is a clear prompt that holds the space.
tilgovi commented Jul 7, 2015

Cool. I'm poking at this and found a couple rough edges. Collapsing annotations while they are being edited results in awkwardly having save/cancel buttons without the annotation body. Hiding these results in a small, excess margin on annotations being edited. Hiding this results in new drafts disappearing completely when collapsed if the user is not logged in. I've mostly addressed all these and I'll push in the morning for your review.

@tilgovi tilgovi merged commit 65b9c3c into master Jul 7, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/travis-ci/push The Travis CI build is in progress
@tilgovi tilgovi deleted the thread-collapsing-redux branch Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment