Thread collapsing redux#2349
Merged
Merged
Conversation
…psing"" This reverts commit 561544e.
Make the tags section use .annotation-body (because tags are a form of body) and put the form actions, reply count, and license messages into the footer so that these collpasing properly and uniformly.
Since there is no username, collapsing a draft when not signed in had been causing the annotation to disappear completely. Now, there is a clear prompt that holds the space.
Contributor
|
Cool. I'm poking at this and found a couple rough edges. Collapsing annotations while they are being edited results in awkwardly having save/cancel buttons without the annotation body. Hiding these results in a small, excess margin on annotations being edited. Hiding this results in new drafts disappearing completely when collapsed if the user is not logged in. I've mostly addressed all these and I'll push in the morning for your review. |
tilgovi
force-pushed
the
thread-collapsing-redux
branch
from
5653095 to
d30a6e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reintroduces the thread collapsing improvements as described in #2337.
It appears that commit cdddb16 broke thread collapsing by hiding the bodies of top level annotations. This has been fixed by a small adjustment to annotations.scss.