Stop two sources of dangling transactions#2381
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
This pathway previously aborted the transaction, and now doesn't. Reraise?
Contributor
Author
|
@nickstenning good to go, thanks for the review |
Two sources of dangling transactions: - WebSocket Solved by releasing the transaction after checking features, avoiding a transaction to get the user for every 'more_hits' call, and the general hygiene of processing messages in a transaction. - Notification worker Process messages in a transaction.
tilgovi
force-pushed
the
cleanup-transactions
branch
from
1031860 to
560aa5e
Compare
I will see you again, soon, streamer.py. Soon.
Contributor
Author
|
There, that should get the tests passing. |
Contributor
Author
|
Should I do anything else here? |
nickstenning
added a commit
that referenced
this pull request
Jul 21, 2015
Stop two sources of dangling transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sources of dangling transactions:
Solved by releasing the transaction after checking features,
avoiding a transaction to get the user for every 'more_hits' call,
and the general hygiene of processing messages in a transaction.
Process messages in a transaction.