bug: renderRect blur not clipped by rounding

[jmanc3]

g_pHyprOpenGL->renderRect was recently broken in that when it draws a rounded rectangle, with blur, the blur in the corners aren't clipped. You can most notice it in hyprbars with blur enabled, but also in plugins which use the function. I think this commit is responsible but I didn't check for sure: 6fce2d7

[tekstryder]

Related and/or possible dupe of:

• [Regression] Scaling artifacts on modals #13119

Bisected to the same commit.

EDIT: See also #12024 for when those rectangles were fixed.

[giacomozama]

This bug is still there, isn't it?

[giacomozama]

This appears to fix the problem on my end. I'm doing the same thing renderTextureWithBlurInternal does i.e. calculating the monitor space box to set the UV on the blur texture.

However, I'm hesitant on opening a PR cause 1) I can't understand why this wasn't necessary before, and 2) I'm not sure this doesn't conflict with anything.

Wish someone would give this a look

diff --git a/src/render/OpenGL.cpp b/src/render/OpenGL.cpp
index 31a6928e..1fbce27c 100644
--- a/src/render/OpenGL.cpp
+++ b/src/render/OpenGL.cpp
@@ -1056,8 +1056,31 @@ void CHyprOpenGLImpl::renderRectWithBlurInternal(const CBox& box, const CHyprCol
     g_pHyprRenderer->pushMonitorTransformEnabled(true);
     const auto SAVEDRENDERMODIF               = g_pHyprRenderer->m_renderData.renderModif;
     g_pHyprRenderer->m_renderData.renderModif = {}; // fix shit
-    renderTexture(blurredBG, MONITORBOX,
-                  STextureRenderData{.damage = &damage, .a = data.blurA, .round = data.round, .roundingPower = 2.F, .allowCustomUV = false, .allowDim = false, .noAA = false});
+
+    auto& m_renderData = g_pHyprRenderer->m_renderData;
+
+    CBox  transformedBox = box;
+    transformedBox.transform(Math::wlTransformToHyprutils(Math::invertTransform(m_renderData.pMonitor->m_transform)), m_renderData.pMonitor->m_transformedSize.x,
+                             m_renderData.pMonitor->m_transformedSize.y);
+
+    CBox monitorSpaceBox = {transformedBox.pos().x / m_renderData.pMonitor->m_pixelSize.x * m_renderData.pMonitor->m_transformedSize.x,
+                            transformedBox.pos().y / m_renderData.pMonitor->m_pixelSize.y * m_renderData.pMonitor->m_transformedSize.y,
+                            transformedBox.width / m_renderData.pMonitor->m_pixelSize.x * m_renderData.pMonitor->m_transformedSize.x,
+                            transformedBox.height / m_renderData.pMonitor->m_pixelSize.y * m_renderData.pMonitor->m_transformedSize.y};
+
+    renderTexture(blurredBG, box,
+                  STextureRenderData{
+                      .damage                      = &damage,
+                      .a                           = data.blurA,
+                      .round                       = data.round,
+                      .roundingPower               = data.roundingPower,
+                      .allowCustomUV               = true,
+                      .allowDim                    = false,
+                      .noAA                        = false,
+                      .primarySurfaceUVTopLeft     = monitorSpaceBox.pos() / m_renderData.pMonitor->m_transformedSize,
+                      .primarySurfaceUVBottomRight = (monitorSpaceBox.pos() + monitorSpaceBox.size()) / m_renderData.pMonitor->m_transformedSize,
+                  });
+
     g_pHyprRenderer->popMonitorTransformEnabled();
     g_pHyprRenderer->m_renderData.renderModif = SAVEDRENDERMODIF;
 

giacomozama@8c44983

EDIT: in the meanwhile, I've implemented this as a plugin here https://github.com/giacomozama/renderrect-blur-fix

[Haku-taku]

I can confirm that the patch works perfectly

[jmanc3]

@giacomozama does it still correctly blur the background, and does it work on multiple monitors?