fix(config/Lua): check "workspace" instead of "id" in hl.workspace.move/rename - #14232
Merged
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
vaxerski
approved these changes
May 1, 2026
…ead of "id" as a parameter
Contributor
Author
|
Synced to pick up the upstream gtests fix (c7b8fe1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the wiki, this should work:
hl.dsp.workspace.move({ workspace = 1, monitor = "current" })source
However, it doesn't, because "id" is expected in the Lua table instead of "workspace". "workspace" should be correct here because it's more descriptive and in line with all similar dispatchers. These were the only occurences of this mismatch I could find.
Very small and simple fix, so should be ready to merge.