[DYOD] Data Definition Language (DDL) Project #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauck
reviewed
Jul 10, 2021
klauck
reviewed
Jul 10, 2021
Contributor
|
@simonstadlinger please provide a high-level summary of this pull request as the description. In addition, please pick a more descriptive title for the PR, using the prefix |
simonstadlinger
changed the title
mweisgut
reviewed
Sep 23, 2021
mweisgut
reviewed
Sep 23, 2021
dey4ss
reviewed
Sep 29, 2021
mweisgut
dismissed
their stale review
I'm contributing now so another person should approve.
dey4ss
approved these changes
Oct 11, 2021
test/sql_tests.cpp
Outdated
| ASSERT_EQ(stmt->ifExists, true); | ||
| } | ||
|
|
||
|
|
test/sql_tests.cpp
Outdated
| ASSERT_STREQ(stmt->name, "students"); | ||
| } | ||
|
|
||
|
|
mweisgut
changed the title
mweisgut
added a commit
that referenced
this pull request
Jan 14, 2022
PR #177 added additional column types, including `SMALLINT`. However, SMALLINT was not added as a token for the lexical analysis (flex scanner). This PR adds `SMALLINT` as a token and extends a test case so that all column types are tested with a `CREATE TABLE` SQL statement. Furthermore, this PR eliminates the `ColumnSpecification` struct, which was used before to store precision and scale information for the DECIMAL or TIME column types. Similar to the `ColumnType::length`, `precision` and `scale` are now member variables of `ColumnType`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sums up all the work for project 1 of this term "Develop your Own Database" seminar. The project's high-level goal is to make the schema SQL of hyrise executable.
Specifically, this pull request - once finished - will include the extension of the parser to support CREATE INDEX and DROP INDEX statements, column and table key constraints, a subset of ALTER TABLE statements, and extended type parsing within column definitions.