CreateTable: add SMALLINT | Remove ColumnSpecification #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweisgut
changed the title
klauck
reviewed
Jan 13, 2022
klauck
reviewed
Jan 13, 2022
klauck
reviewed
Jan 13, 2022
klauck
reviewed
Jan 13, 2022
klauck
reviewed
Jan 13, 2022
klauck
reviewed
Jan 13, 2022
klauck
approved these changes
Jan 13, 2022
Contributor
klauck
left a comment
klauck
left a comment
There was a problem hiding this comment.
Looks good to me. I have added minor improvement proposals as comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #177 added additional column types, including
SMALLINT. However, SMALLINT was not added as a token for the lexical analysis (flex scanner). This PR addsSMALLINTas a token and extends a test case so that all column types are tested with aCREATE TABLESQL statement.Furthermore, this PR eliminates the
ColumnSpecificationstruct, which was used before to store precision and scale information for the DECIMAL or TIME column types. Similar to theColumnType::length,precisionandscaleare now member variables ofColumnType.