Enable Queries on Imported/Exported Tables#225
Conversation
Bouncner
left a comment
Bouncner
left a comment
There was a problem hiding this comment.
I don't have much to say.
|
Fine from my side, but as I am not familiar with the parser, maybe wait for another approval? |
| // Specify code that is included in the generated .h and .c files | ||
| // clang-format off | ||
| %code requires { | ||
| // clang-format on |
There was a problem hiding this comment.
Why remove? Does clang complain about the format?
There was a problem hiding this comment.
To be honest, gonna have to look into this after that time. Think that clang-format at that time (probably 14 or so) did some weird stuff then. The clang-format comments don't suppress clang-tidy/linter warnings, but prevent clang-format from reformating the enclosed lines (e.g., indentation, which does not work well in the parser file since it's not really a C++ source file).
There was a problem hiding this comment.
Indeed, clang-format (15) locally screws up the indentation and even adds linebreaks in the bison control lines.
|
Argh, Travis doesn't wanna work again 😡 |
|
Mailing TravisCI? :-/ |
|
Yeah, already did that. Let's see what happens. |
|
They fixed it. |
3 participants
In hyrise/hyrise#2514, we sketched how filtering and encoding selection during import and export of tables does look like in Posgtres [1]. After a discusison in the weekly, this PR enables filters on import/export of tables. The export filter will also be implemented in Hyrise.
[1] https://www.postgresql.org/docs/15/sql-copy.html