Skip to content

HC-632: Fixed sds pkg export command to properly set the legacy url field#116

Merged
mcayanan merged 2 commits into
developfrom
HC-632
May 19, 2026
Merged

HC-632: Fixed sds pkg export command to properly set the legacy url field#116
mcayanan merged 2 commits into
developfrom
HC-632

Conversation

@mcayanan

Copy link
Copy Markdown
Contributor

This PR fixes a bug in the sds pkg export command so that it can properly set the legacy url field to just the basename of the tar package file name. Previously, it was set to the full S3 url. Here's an example of what was seen in the manifest.json of the SDS package:

(mozart) [hysdsops@ip-100-104-3-76 tmp]$ more container-hysds_lightweight-jobs-v2.0.2.sdspkg/manifest.json 
{
  "containers": {
    "digest": "sha256:1b6868aee5ec5b43c6b72d1438879005491e76355901982f2e4b3cc356cf3d98",
    "id": "container-hysds_lightweight-jobs:v2.0.2",
    "url": "s3://swot-dev-cc-fwd-pop/container-hysds_lightweight-jobs-v2.0.2.tar.gz",
    "urls": "{\"x86_64\": \"container-hysds_lightweight-jobs-v2.0.2.tar.gz\", \"amd64\": \"container-hysds_lightweight-jobs-v2.0.2.tar.gz\", \"arm64\": \"container-hysds_lightweight-jobs-v2.0.2-arm64.tar.gz\", \"aarch64\": \"container-hysds_li
ghtweight-jobs-v2.0.2-arm64.tar.gz\"}",
    "version": "v2.0.2"
  },
...

Testing

After performing an sds pkg export command on the lightweight jobs package, I examined the mainfest.json file in the sdspkg file and verified that url contained just the file name now:

(mozart) [hysdsops@ip-100-104-3-76 tmp]$ more container-hysds_lightweight-jobs-v2.0.2.sdspkg/manifest.json 
{
  "containers": {
    "digest": "sha256:1b6868aee5ec5b43c6b72d1438879005491e76355901982f2e4b3cc356cf3d98",
    "id": "container-hysds_lightweight-jobs:v2.0.2",
    "url": "container-hysds_lightweight-jobs-v2.0.2.tar.gz",
    "urls": "{\"x86_64\": \"container-hysds_lightweight-jobs-v2.0.2.tar.gz\", \"amd64\": \"container-hysds_lightweight-jobs-v2.0.2.tar.gz\", \"arm64\": \"container-hysds_lightweight-jobs-v2.0.2-arm64.tar.gz\", \"aarch64\": \"container-hysds_li
ghtweight-jobs-v2.0.2-arm64.tar.gz\"}",
    "version": "v2.0.2"
  },
  "hysds_ios": [
    {
      "id": "hysds-io-lightweight-echo:v2.0.2",
      "job-specification": "job-lightweight-echo:v2.0.2",
      "job-version": "v2.0.2",
      "label": "echo",
      "params": [
        {
          "from": "value",
          "name": "echo_var",
          "value": "Hello world!"
        }
      ],
      "resource": "hysds-io-specification",
      "submission_type": "individual"
    },

@mcayanan mcayanan requested a review from pymonger May 18, 2026 20:41
@mcayanan mcayanan merged commit 0b1be70 into develop May 19, 2026
@mcayanan mcayanan deleted the HC-632 branch May 19, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants