Restrict package-script trimming to ASCII whitespace - #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String.trim()in Node and Jest/Vitest package-script recognition with ASCII space/tab-only edge trimmingdistand document the boundary in the changelogWhy
The parsers already normalized only
[ \t]+internally after the multiline hardening, but both still calledString.trim()first. JavaScripttrim()removes a wider Unicode whitespace set, including NBSP. A package script such asnode --test\u00a0or\u00a0jest --cicould therefore be normalized by ProofDiff into a supported exact-target command even though that non-ASCII character is not ordinary shell separator whitespace. That creates a semantic mismatch between the repository script and the targeted command ProofDiff actually runs.The fix narrows edge trimming to exactly spaces and tabs, matching the parser's existing internal normalization boundary.
Verification
npm testpassed after the changenpm run clean && npm run buildpassed