Floor findimports at the first MIT release - #7
Merged
Conversation
unbox is Apache-2.0 and depends on findimports, which was GPL-2.0-or-later through 2.3.0 and MIT from 2.4.0 (2024-02-01) onward. The dependency was declared unpinned, so the licence outcome was accidental rather than stated: a fresh resolve happens to pick an MIT release, but a constraints file, an old lockfile or a stale wheel cache could select a GPL-era one. `findimports>=2.4` makes the guarantee explicit at zero cost. The dependency stays required -- it is load-bearing (unbox subclasses ModuleGraph) -- and current resolves are unaffected: latest is 3.0.0, and unbox already requires Python >=3.11 while findimports 3.0.0 requires >=3.10. Suite unchanged at 32 passed. Claude-Session: https://claude.ai/code/session_01Kug7UUbVeCQgruvNXUq63c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unboxis Apache-2.0 and depends onfindimports, which was GPL-2.0-or-later through 2.3.0 and MIT from 2.4.0 (2024-02-01, upstream issue 27) onward. Latest is 3.0.0, MIT.The dependency was declared unpinned, so the licence outcome was accidental rather than stated: a fresh resolve happens to pick an MIT release, but a constraints file, an old lockfile or a stale wheel cache could select a GPL-era one.
findimports>=2.4makes the guarantee explicit at zero cost.Why not make it optional
That was the original plan, on the belief that
findimportswas still GPL. It is not, so an opt-in extra would have bought nothing and cost real UX — the dependency is load-bearing (unboxsubclassesModuleGraph; without itunboxdoes essentially nothing). It stays required.Worth recording why the belief was wrong, since it will mislead the next reader too: findimports 2.x still carries a stale GPL paragraph inside its module docstring, ~30 lines above
__licence__ = 'MIT'. Any scan that greps source text for "GNU General Public License" flags it; reading the distribution metadata, the bundled LICENSE, or the trove classifier does not. That blurb is gone in 3.0.0.Verified
GPL v2 or later; 2.0.0–2.3.0GPL v2 or v3; 2.4.0/2.5.0/2.6.0/3.0.0MIT.dist-info/licenses/LICENSEis the MIT text.unboxrequires Python >=3.11, findimports 3.0.0 requires >=3.10.https://claude.ai/code/session_01Kug7UUbVeCQgruvNXUq63c