evdi: colour management follow-ups (damage, cursor, color_props) - #1
Open
onetr1ck wants to merge 3 commits into
Open
evdi: colour management follow-ups (damage, cursor, color_props)#1onetr1ck wants to merge 3 commits into
onetr1ck wants to merge 3 commits into
Conversation
Colour is applied only while copying dirty rects for GRABPIX. A compositor can update GAMMA_LUT or CTM without repainting, so force a full-frame dirty on color_mgmt_changed and let the existing update-ready path re-grab.
When cursor events are disabled the cursor is alpha-blended from the untinted GEM into the grab buffer after the primary copy. Apply the same CTM/gamma to the composed pixel so Night Light matches the desktop under the pointer.
Advertise both colour properties by default. color_props=gamma or color_props=ctm limits what the CRTC exposes so a compositor can be forced onto one Night Light path for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on your software colour management branch. Three small follow-ups from testing DisplayLink with GNOME Night Light.
Colour updates now mark the full scanout dirty so a static desktop re-grabs after GAMMA_LUT or CTM changes. The software cursor blend path applies the same transform as the primary copy. A color_props module parameter (both, gamma, or ctm) can limit which DRM properties are advertised when comparing compositor paths.
Happy for you to take these into the upstream PR as-is, or drop any piece you do not want. No change to the core apply path beyond wiring.