docs: add concurrent encryption examples (Promise.all / Promise.allSettled) - #88
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
abbesBenayache
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation guidance for encrypting multiple inputs concurrently with the JS SDK, helping developers choose between fail-fast vs. partial-success concurrency patterns when calling encryptInput.
Changes:
- Document concurrent
encryptInputusage withPromise.all. - Document concurrent
encryptInputusage withPromise.allSettledand per-item error handling. - Add a note about Handle Gateway rate limiting for high concurrency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+263
to
+267
| const [sell, minBuy, bid] = await Promise.all([ | ||
| handleClient.encryptInput(sellAmount, 'uint256', CONTRACT_ADDRESS), | ||
| handleClient.encryptInput(minBuyAmount, 'uint256', CONTRACT_ADDRESS), | ||
| handleClient.encryptInput(bidAmount, 'uint256', CONTRACT_ADDRESS), | ||
| ]); |
64ix
added a commit
that referenced
this pull request
Jul 6, 2026
Resolves conflict in encryptInput.md: keeps both the fromExternal cross-link (this branch) and the concurrent encryption section added by #88 on main, back to back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.