Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Oct 7, 2025

  • With this PR we only have one interface (no v6 and v8 anymore).
  • Global interfaces IexecInterfaceNative and IexecInterfaceToken are updated to have all PoCo functions including ABILegacy ones (IexecInterfaceNative(Token)ABILegacy has been merged with IexecInterfaceNative(Token)).
  • Global interfaces are used in tests whenever possible to make sure they are kept up-to-date.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.83%. Comparing base (f7c634b) to head (d1bf68b).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   83.66%   84.83%   +1.17%     
==========================================
  Files          38       37       -1     
  Lines        1218     1240      +22     
  Branches      227      235       +8     
==========================================
+ Hits         1019     1052      +33     
+ Misses        199      188      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi self-assigned this Oct 8, 2025
@zguesmi zguesmi marked this pull request as ready for review October 8, 2025 07:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates interface definitions by removing version-specific interfaces (v6 and v8) and updating global interfaces IexecInterfaceNative and IexecInterfaceToken to include all PoCo functions, including legacy ABI functions. The interfaces are now used more widely in tests to ensure they stay up-to-date.

Key changes:

  • Removal of version-specific interface files and consolidation into single interfaces
  • Updated global interfaces to include both current and legacy ABI functions
  • Replaced specific interface imports with unified global interfaces throughout test files

Reviewed Changes

Copilot reviewed 42 out of 44 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/utils/IexecWrapper.ts Refactored to use unified IexecInterfaceNative instead of multiple specific interfaces
test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts Updated to use IexecInterfaceNative instead of IexecAccessors
test/byContract/IexecPoco/IexecPoco2-claim.test.ts Fixed type inconsistency by changing taskIndex from number to bigint
test/byContract/IexecPoco/IexecPoco1.test.ts Updated interface usage and removed outdated comments
contracts/interfaces/*.sol Updated pragma versions and consolidated interface definitions
contracts/IexecInterface*.sol Major refactoring to include comprehensive function sets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@zguesmi zguesmi merged commit e50bfb4 into main Oct 9, 2025
9 checks passed
@zguesmi zguesmi deleted the refactor/update-global-interfaces branch October 9, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants