-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Update global interfaces #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 83.66% 84.83% +1.17%
==========================================
Files 38 37 -1
Lines 1218 1240 +22
Branches 227 235 +8
==========================================
+ Hits 1019 1052 +33
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates interface definitions by removing version-specific interfaces (v6 and v8) and updating global interfaces IexecInterfaceNative and IexecInterfaceToken to include all PoCo functions, including legacy ABI functions. The interfaces are now used more widely in tests to ensure they stay up-to-date.
Key changes:
- Removal of version-specific interface files and consolidation into single interfaces
- Updated global interfaces to include both current and legacy ABI functions
- Replaced specific interface imports with unified global interfaces throughout test files
Reviewed Changes
Copilot reviewed 42 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils/IexecWrapper.ts | Refactored to use unified IexecInterfaceNative instead of multiple specific interfaces |
| test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts | Updated to use IexecInterfaceNative instead of IexecAccessors |
| test/byContract/IexecPoco/IexecPoco2-claim.test.ts | Fixed type inconsistency by changing taskIndex from number to bigint |
| test/byContract/IexecPoco/IexecPoco1.test.ts | Updated interface usage and removed outdated comments |
| contracts/interfaces/*.sol | Updated pragma versions and consolidated interface definitions |
| contracts/IexecInterface*.sol | Major refactoring to include comprehensive function sets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Le-Caignec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
IexecInterfaceNativeandIexecInterfaceTokenare updated to have all PoCo functions including ABILegacy ones (IexecInterfaceNative(Token)ABILegacyhas been merged withIexecInterfaceNative(Token)).IexecInterfaceTokenABILegacyis only used by the middleware team and they are aware that they should useIexecInterfaceToken.IexecInterfaceNativeABILegacyis not referenced outside of the PoCo project.