Skip to content

Conversation

@gfournierPro
Copy link
Contributor

This change the printFunctions function to print function selectors instead of function signatures

[88] 0x56625089E6EB6F058DB163025318575AD38781fa viewTask
[89] 0x56625089E6EB6F058DB163025318575AD38781fa viewWorkerpool
[90] 0x56625089E6EB6F058DB163025318575AD38781fa workerpool_stake_ratio
[91] 0x56625089E6EB6F058DB163025318575AD38781fa workerpoolregistry
[92] 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f assertDatasetDealCompatibility
[93] 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f matchOrders
[94] 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f sponsorMatchOrders
[95] 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f verifyPresignature
[96] 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f verifyPresignatureOrSignature
[97] 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f verifySignature

Upgrade completed successfully!
New IexecPocoAccessorsFacet deployed at: 0x56625089E6EB6F058DB163025318575AD38781fa
New IexecPoco1Facet deployed at: 0xC8dE3913fcdBC576970dCe24eE416CA25681f65f

Usefull for future upgrades

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the upgrade-helper script to decode and display function names for diamond facets instead of raw function selectors.

  • Adds imports for all facet factories and builds an array of their interfaces.
  • Replaces logging of raw selectors with logic to resolve each selector to a function name.
  • Introduces special-case handling for 0x00000000 and 0xffffffff.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 106 to 116
for (const iface of allInterfaces) {
try {
const fragment = iface.getFunction(selector);
if (fragment) {
functionName = fragment.name;
break;
}
} catch (error) {
// Continue searching in other interfaces
}
}
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This performs a try/catch for every interface per selector, using exceptions for control flow (getFunction throws when not found). Precompute a Map<selector, fragment> once from allInterfaces (iterating iface.fragments) and then do O(1) lookups, avoiding repeated exception overhead.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.85%. Comparing base (db9c7e3) to head (8de8d5f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files          37       37           
  Lines        1241     1241           
  Branches      235      235           
=======================================
  Hits         1053     1053           
  Misses        188      188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@zguesmi zguesmi merged commit 3ad03af into main Oct 17, 2025
4 checks passed
@zguesmi zguesmi deleted the feat/human-readable-sig branch October 17, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants