Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Dec 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 09:42
@zguesmi zguesmi self-assigned this Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the npm dependencies by moving build-time and development dependencies from dependencies to devDependencies, and removes unused packages. The changes appropriately distinguish between runtime dependencies (needed by consumers of the published package) and development dependencies (only needed for building, testing, and developing the package).

Key Changes

  • Moved @mudgen/diamond-1, createx, and rlc-faucet-contract from dependencies to devDependencies as they are only used at build/compile time
  • Removed @uniswap/v2-periphery and its transitive dependencies (@uniswap/lib, @uniswap/v2-core) which are not used in the codebase
  • Removed explicit solidity-coverage dependency (provided by @nomicfoundation/hardhat-toolbox)
  • Updated comment locations to match the new dependency structure

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Cleaned dependencies section to only include @openzeppelin/contracts; moved diamond, createx, and rlc-faucet-contract to devDependencies; removed uniswap packages and solidity-coverage; updated comment structure
package-lock.json Synchronized lockfile with package.json changes, adding "dev": true and "peer": true flags to moved/peer dependencies and removing uniswap package entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (f50b898) to head (dab7b25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          33       33           
  Lines        1137     1137           
  Branches      228      228           
=======================================
  Hits         1096     1096           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi marked this pull request as ready for review December 3, 2025 09:57
@zguesmi zguesmi changed the title refactor: Clean npm dependencies refactor: Clean npm dependencies & disable postinstall scripts Dec 3, 2025
Copy link
Contributor

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi zguesmi merged commit db44994 into main Dec 3, 2025
5 checks passed
@zguesmi zguesmi deleted the refactor/move-npm-packages-to-dev-deps branch December 3, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants