-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: Clean npm dependencies & disable postinstall scripts #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the npm dependencies by moving build-time and development dependencies from dependencies to devDependencies, and removes unused packages. The changes appropriately distinguish between runtime dependencies (needed by consumers of the published package) and development dependencies (only needed for building, testing, and developing the package).
Key Changes
- Moved
@mudgen/diamond-1,createx, andrlc-faucet-contractfromdependenciestodevDependenciesas they are only used at build/compile time - Removed
@uniswap/v2-peripheryand its transitive dependencies (@uniswap/lib,@uniswap/v2-core) which are not used in the codebase - Removed explicit
solidity-coveragedependency (provided by@nomicfoundation/hardhat-toolbox) - Updated comment locations to match the new dependency structure
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Cleaned dependencies section to only include @openzeppelin/contracts; moved diamond, createx, and rlc-faucet-contract to devDependencies; removed uniswap packages and solidity-coverage; updated comment structure |
| package-lock.json | Synchronized lockfile with package.json changes, adding "dev": true and "peer": true flags to moved/peer dependencies and removing uniswap package entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 33 33
Lines 1137 1137
Branches 228 228
=======================================
Hits 1096 1096
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Le-Caignec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.