Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 21, 2026

🤖 This is an automated pull request created by Upgrade PoCo Facets GitHub Actions
workflow to save upgrade artifacts.

Note: Verify deployment before merging this PR.


Note

Updates Arbitrum deployment artifacts after a diamond upgrade.

  • Removes IexecERC20Facet; reassigns approve, approveAndCall, increase/decreaseAllowance, transfer, and transferFrom to IexecEscrowTokenFacet (ABI expanded with errors CallerIsNotTheRequester, OperationFailed, UnsupportedOperation and events Lock, Unlock, Reward, Seize)
  • Redeploys multiple facets with new addresses (IexecAccessorsABILegacyFacet, IexecCategoryManagerFacet, IexecConfigurationExtraFacet, IexecConfigurationFacet, IexecOrderManagementFacet, IexecPoco1Facet, IexecEscrowTokenFacet)
  • Cleans up ABIs by dropping legacy constant accessors (e.g., ratios/owner) across several facets
  • Diamond now has 13 facets (down from 14); function routing updated accordingly in .diamond.log

Written by Cursor Bugbot for commit bf31fd7. This will update automatically on new commits. Configure here.

@zguesmi zguesmi marked this pull request as ready for review January 21, 2026 11:27
Copilot AI review requested due to automatic review settings January 21, 2026 11:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This automated PR saves upgrade artifacts from the "Upgrade PoCo Facets" GitHub Actions workflow for the Arbitrum network (run ID: 21206392301). The changes update deployment addresses, modify ABIs, and reflect changes to the diamond proxy facets.

Changes:

  • Updated deployment addresses for multiple facets (IexecRelayFacet, IexecPocoAccessorsFacet, IexecPoco2Facet, IexecPoco1Facet, IexecOrderManagementFacet, IexecEscrowTokenFacet)
  • Removed several constant getter functions from ABIs (CONTRIBUTION_DEADLINE_RATIO, FINAL_DEADLINE_RATIO, GROUPMEMBER_PURPOSE, KITTY_ADDRESS, KITTY_MIN, KITTY_RATIO, REVEAL_DEADLINE_RATIO, WORKERPOOL_STAKE_RATIO, owner)
  • Modified event parameter names in IexecPoco2Facet (taskId → taskid)
  • Enhanced IexecEscrowTokenFacet with new error types, restructured events, and added ERC20 functions (approve, transfer, increaseAllowance, decreaseAllowance)
  • Updated diamond proxy logs to reflect facet address changes

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
deployments/arbitrum/IexecRelayFacet.json Address changed, ABI cleaned up (removed constant getters), bytecode updated
deployments/arbitrum/IexecPocoAccessorsFacet.json Address changed, numDeployments incremented to 3, bytecode updated
deployments/arbitrum/IexecPoco2Facet.json Address changed, event parameter names lowercased (taskId→taskid), ABI cleaned up, numDeployments incremented to 2
deployments/arbitrum/IexecPoco1Facet.json Address changed, numDeployments incremented to 3, bytecode updated
deployments/arbitrum/IexecOrderManagementFacet.json Address changed, ABI cleaned up (removed constant getters), numDeployments incremented to 2
deployments/arbitrum/IexecEscrowTokenFacet.json Address changed, added error types and ERC20 functions, restructured events, numDeployments incremented to 2
deployments/arbitrum/.diamond.log Updated facet count and addresses to match new deployments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"indexed": true,
"internalType": "bytes32",
"name": "taskId",
"name": "taskid",
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event parameter name has been changed from "taskId" to "taskid" (lowercase). This is a breaking change that could affect event listeners and indexers that rely on the exact parameter name. Consider whether this naming change is intentional and ensure all dependent systems are updated accordingly.

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (5b1ec5d) to head (bf31fd7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          33       33           
  Lines        1137     1137           
  Branches      214      228   +14     
=======================================
  Hits         1096     1096           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi merged commit 55c668a into main Jan 21, 2026
15 checks passed
@zguesmi zguesmi deleted the chore/save-upgrade-artifacts-arbitrum-21206392301 branch January 21, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants