Remove RESULT_UPLOAD_REQUESTED & RESULT_UPLOAD_REQUEST_TIMEOUT
#440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-toussaint
approved these changes
Oct 7, 2021
| .getNbReplicatesWithCurrentStatus(task.getChainTaskId(), | ||
| ReplicateStatus.RESULT_UPLOADING) > 0; | ||
|
|
||
| if (isThereAWorkerUploading) { |
james-toussaint
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third step of #434: remove
RESULT_UPLOAD_REQUESTED&RESULT_UPLOAD_REQUEST_TIMEOUTfrom tasks workflow.They did not give more information than
RESULT_UPLOADING&RESULT_UPLOAD_TIMEOUTso they were redundant.Previous transitions to
RESULT_UPLOAD_REQUESTEDnow make the task transition toRESULT_UPLOADING.Previous transitions to
RESULT_UPLOAD_REQUEST_TIMEOUTnow make the task transition toRESULT_UPLOAD_TIMEOUT.