Fix issue #188 #189
Merged
Fix issue #188 #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| switch (interruptedReplicate.getRecoveryAction()) { | ||
| case WAIT: | ||
| subscriptionService.subscribeToTopic(chainTaskId); | ||
| resultService.saveResultInfo(chainTaskId, replicateModel); |
Contributor
There was a problem hiding this comment.
Just wondering, couldn't we resultService.saveResultInfo(chainTaskId, replicateModel); once for all at the beginning of the recoverReplicate(..) method (so we don't miss any case)?
Member
Author
There was a problem hiding this comment.
Actually, we don't need it for all cases.
| case COMPLETE: | ||
| taskExecutorService.completeTask(chainTaskId); | ||
| break; | ||
| if (!isResultAvailable && recoveryAction != RecoveryAction.CONTRIBUTE) { |
Contributor
There was a problem hiding this comment.
What do you think about something like:
isResultRequired = (recoveryAction == WAIT ||recoveryAction == CONTRIBUTE || recoveryAction == REVEAL recoveryAction == UPLOAD_RESULT);
if(!isResultAvailable && isResultRequired){
log.error(..)
continue;
}
Member
Author
There was a problem hiding this comment.
Yes, it's clearer. But when recoveryAction == CONTRIBUTE the result is not necessarily needed because we can re-do the computation.
So I'd say:
isResultRequired = Arrays.asList(WAIT, REVEAL, UPLOAD_RESULT).contains(recoveryAction);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.