Notification type for recovery #201
Conversation
|
|
||
| ContributionAuthorization contributionAuth = interruptedReplicate.getContributionAuthorization(); | ||
| RecoveryAction recoveryAction = interruptedReplicate.getRecoveryAction(); | ||
| ContributionAuthorization contributionAuth = missedTaskNotification.getTaskNotificationExtra().getContributionAuthorization(); |
There was a problem hiding this comment.
The contributionAuth is not going to be there every time, instead, we can get the chainTaskId from the taskNotification itself.
|
|
||
| if (!oReplicateModel.isPresent()) { | ||
| if (!optionalTaskDescription.isPresent()) { | ||
| log.error("Could not recover task, no replicateModel retrieved [chainTaskId:{}, RecoveryAction:{}]", |
There was a problem hiding this comment.
maybe replace "replicateModel" with "task description" for consistency sake.
|
|
||
| @PostConstruct | ||
| public void initIt() { | ||
| corePublicAddress = customFeignClient.getPublicConfiguration().getSchedulerPublicAddress(); |
There was a problem hiding this comment.
We can use "publicConfigurationService.getSchedulerPublicAddress()" instead of sending another HTTP request.
| @Async | ||
| private String compute(AvailableReplicateModel replicateModel) { | ||
| ContributionAuthorization contributionAuth = replicateModel.getContributionAuthorization(); | ||
| private String compute(ContributionAuthorization contributionAuth) { |
There was a problem hiding this comment.
If the goal is to use "contributionAuth" only in the contribute() logic we should pass the TaskDescription instead. That would also remove the repeated call "getTaskDescriptionFromChain(chainTaskId)".
There was a problem hiding this comment.
Yes, that was the initial plan, but in a future PR :)
| } | ||
|
|
||
|
|
||
| public void tryToContribute(ContributionAuthorization contributionAuth) { |
There was a problem hiding this comment.
I think it would be better to replace this method by an "isReadyToContribute()" method and use it in the subscriptionService so the latter stays the entrypoint that explicitly creates replicates (even when recovering)
There was a problem hiding this comment.
Yes, we are going to tune that in a second time
No description provided.