feat: re add verification script #80

gfournierPro · 2025-07-21T13:20:16Z

2 new scripts to :

extract proxy smart contract address from config.json
get the implementatiton address since we did not want to save them on deploy

…xy and implementation verification

codecov · 2025-07-21T13:24:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3c7288e). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   83.78%           
=======================================
  Files           ?        4           
  Lines           ?      111           
  Branches        ?        7           
=======================================
  Hits            ?       93           
  Misses          ?       17           
  Partials        ?        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scripts/get_config_address.sh

scripts/get_implementation_address.sh

verification.mk

…tion extraction and proxy address retrieval

tools/get_config_address.sh

tools/verification.mk

Copilot

Pull Request Overview

This PR adds verification functionality for smart contracts by introducing two new scripts that extract proxy contract addresses from configuration files and retrieve implementation addresses without storing them during deployment.

Adds a comprehensive Makefile-based verification system for proxy and implementation contracts
Introduces a Solidity script to extract configuration information and proxy implementation addresses
Updates the main Makefile to include the new verification tools

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File	Description
tools/verification.mk	Comprehensive Makefile with verification functions and targets for Sepolia and Arbitrum Sepolia networks
script/GetConfigInfo.s.sol	Solidity script to extract config fields and implementation addresses from proxy contracts
Makefile	Updated to include the new verification.mk file

tools/verification.mk

Copilot · 2025-07-22T08:58:36Z

tools/verification.mk

+
+
+# ========================================================================
+#							COMPLETION TARGETS


Inconsistent tab usage in comment formatting. This line uses tabs while other comment lines use spaces for alignment.

Suggested change

# COMPLETION TARGETS

# COMPLETION TARGETS

script/GetConfigInfo.s.sol

Le-Caignec · 2025-07-22T11:52:30Z

script/GetConfigInfo.s.sol

+        if (keccak256(bytes(field)) == keccak256("initialAdmin")) {
+            return config.initialAdmin;
+        } else if (keccak256(bytes(field)) == keccak256("initialPauser")) {
+            return config.initialPauser;
+        } else if (keccak256(bytes(field)) == keccak256("initialUpgrader")) {
+            return config.initialUpgrader;
+        } else if (keccak256(bytes(field)) == keccak256("createxFactory")) {
+            return config.createxFactory;
+        } else if (keccak256(bytes(field)) == keccak256("lzEndpoint")) {
+            return config.lzEndpoint;
+        } else if (keccak256(bytes(field)) == keccak256("rlcToken")) {
+            return config.rlcToken;
+        } else if (keccak256(bytes(field)) == keccak256("rlcLiquidityUnifierAddress")) {
+            return config.rlcLiquidityUnifierAddress;
+        } else if (keccak256(bytes(field)) == keccak256("rlcCrosschainTokenAddress")) {
+            return config.rlcCrosschainTokenAddress;
+        } else if (keccak256(bytes(field)) == keccak256("iexecLayerZeroBridgeAddress")) {
+            return config.iexecLayerZeroBridgeAddress;
+        } else {
+            revert("Unknown field");


why we not use config.readAddress(field) here ?

don't know this fct sry

feat: update GetConfigInfo script to use config field names and impro…

Le-Caignec · 2025-07-22T12:00:07Z

script/GetConfigInfo.s.sol

+    function getConfigField(string calldata chain, string calldata field) external view {
+        address value = _getConfigFieldAddress(chain, field);
+        console.log(value);
+    }


Is this function really necessary ?

To mutualise the _getConfigFieldAddress btw getConfigField and getImplementationAddress

…ve address retrieval logic

…cToken

zguesmi · 2025-07-22T14:56:36Z

tools/verification.mk

+# Parameters: CONTRACT_NAME, NETWORK, CONFIG_KEY, CHAIN_ID, DISPLAY_NAME, CONTRACT_PATH, RPC_URL, CONSTRUCTOR_ARGS
+define verify-impl
+	@echo "Verifying $(1) Implementation on $(5)..."
+	@proxy_address=$$(forge script script/GetConfigInfo.s.sol --sig "getConfigField(string,string)" $(2) $(3) 2>/dev/null | grep "0x" | tail -n1); \


Suggested change

@proxy_address=$$(forge script script/GetConfigInfo.s.sol --sig "getConfigField(string,string)" $(2) $(3) 2>/dev/null | grep "0x" | tail -n1); \

@proxy_address=$$(forge script script/GetConfigInfo.s.sol --sig "getConfigField(string,string)" $(2) $(3) 2>/dev/null | grep "0x" | tail -n1);

And all others.

zguesmi · 2025-07-22T14:57:22Z

tools/verification.mk

+define verify-impl
+	@echo "Verifying $(1) Implementation on $(5)..."
+	@proxy_address=$$(forge script script/GetConfigInfo.s.sol --sig "getConfigField(string,string)" $(2) $(3) 2>/dev/null | grep "0x" | tail -n1); \
+	impl_address=$$(forge script script/GetConfigInfo.s.sol --sig "getImplementationAddress(string,string)" $(2) $(3) --rpc-url $(7) 2>/dev/null | grep "0x" | tail -n1); \


Suggested change

impl_address=$$(forge script script/GetConfigInfo.s.sol --sig "getImplementationAddress(string,string)" $(2) $(3) --rpc-url $(7) 2>/dev/null | grep "0x" | tail -n1); \

@impl_address=$$(forge script script/GetConfigInfo.s.sol --sig "getImplementationAddress(string,string)" $(2) $(3) --rpc-url $(7) 2>/dev/null | grep "0x" | tail -n1);

Trying to do so but can't make it work

zguesmi · 2025-07-22T15:05:00Z

script/GetConfigInfo.s.sol

+    function getConfigField(string calldata chain, string calldata field) external view {
+        address value = _getConfigFieldAddress(chain, field);


Why not:

function getConfigField(string calldata path) external view { string memory config = vm.readFile("config/config.json"); address value = config.readAddress(path); ...

and call it with .initialAdmin and .chains.sepolia.rlcLiquidityUnifierAddress

…nd updating address retrieval logic

gfournierPro added 2 commits July 21, 2025 13:49

feat: add verification scripts for proxy and implementation contracts

2f10afe

feat: refactor verification targets to use reusable functions for pro…

0ba9d73

…xy and implementation verification

gfournierPro requested review from Le-Caignec, Copilot and zguesmi July 21, 2025 13:20

gfournierPro self-assigned this Jul 21, 2025

This comment was marked as outdated.

Sign in to view

zguesmi reviewed Jul 21, 2025

View reviewed changes

scripts/get_config_address.sh Outdated Show resolved Hide resolved

scripts/get_config_address.sh Outdated Show resolved Hide resolved

scripts/get_implementation_address.sh Outdated Show resolved Hide resolved

verification.mk Outdated Show resolved Hide resolved

gfournierPro added 8 commits July 21, 2025 20:16

Merge branch 'main' into feature/re-add-verification-script

27cf969

feat: change folder from scripts/ to tools/

c36f051

feat: simplify address extraction logic in get_config_address.sh

bec88aa

feat: update constructor argument handling in verification scripts

9cc00a4

feat: streamline implementation verification process in verification.mk

2829f2d

feat: replace bash scripts with Solidity implementation for configura…

e6d06b1

…tion extraction and proxy address retrieval

feat: remove commented-out code for lzChainId in GetConfigInfo script

7158c40

feat: remove outdated comments and documentation from verification.mk

0410d89

Le-Caignec approved these changes Jul 22, 2025

View reviewed changes

tools/get_config_address.sh Outdated Show resolved Hide resolved

tools/verification.mk Show resolved Hide resolved

gfournierPro requested a review from Copilot July 22, 2025 08:57

fix: forge fmt

29d5af6

Copilot AI reviewed Jul 22, 2025

View reviewed changes

Le-Caignec reviewed Jul 22, 2025

View reviewed changes

gfournierPro added 4 commits July 22, 2025 14:45

feat: update GetConfigInfo script to use config field names and impro…

c25f1c7

…ve address retrieval logic

fix: forge fmt

61a0c49

feat: remove unused import of ConfigLib from GetConfigInfo script

013ce86

fix: update GetConfigInfo script to retrieve rlcAddress instead of rl…

e1d927e

…cToken

zguesmi reviewed Jul 22, 2025

View reviewed changes

zguesmi approved these changes Jul 22, 2025

View reviewed changes

refactor: simplify GetConfigInfo script by removing chain parameter a…

ec8391b

…nd updating address retrieval logic

gfournierPro merged commit 9029aa7 into main Jul 23, 2025
4 checks passed

gfournierPro deleted the feature/re-add-verification-script branch July 23, 2025 06:39

iexec-release-please-app bot mentioned this pull request Jul 21, 2025

chore(main): release 0.1.0-rc #12

Merged



		# ========================================================================
		# COMPLETION TARGETS

	@proxy_address=$$(forge script script/GetConfigInfo.s.sol --sig "getConfigField(string,string)" $(2) $(3) 2>/dev/null \| grep "0x" \| tail -n1); \
	@proxy_address=$$(forge script script/GetConfigInfo.s.sol --sig "getConfigField(string,string)" $(2) $(3) 2>/dev/null \| grep "0x" \| tail -n1);

	impl_address=$$(forge script script/GetConfigInfo.s.sol --sig "getImplementationAddress(string,string)" $(2) $(3) --rpc-url $(7) 2>/dev/null \| grep "0x" \| tail -n1); \
	@impl_address=$$(forge script script/GetConfigInfo.s.sol --sig "getImplementationAddress(string,string)" $(2) $(3) --rpc-url $(7) 2>/dev/null \| grep "0x" \| tail -n1);

		function getConfigField(string calldata chain, string calldata field) external view {
		address value = _getConfigFieldAddress(chain, field);

feat: re add verification script #80

feat: re add verification script #80

Uh oh!

Conversation

gfournierPro commented Jul 21, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 21, 2025 •

edited

Loading