feat: Add support syncing extra config paths#29
Conversation
Summary of ChangesHello @iHildy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the configuration synchronization capabilities by introducing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for syncing extra configuration paths, mirroring existing functionality for secrets, and includes support for syncing entire directories. However, it contains two critical path traversal vulnerabilities in the manifest handling logic. These vulnerabilities could allow a malicious or compromised repository to read arbitrary files or modify file permissions outside the intended sync directories, due to a lack of proper validation for repoPath and relativePath fields in the sync manifest against directory traversal sequences or absolute paths. While the implementation is otherwise robust, featuring a clean refactoring and good structure, there is one minor suggestion to improve the clarity of a generalized function. Strict path validation is recommended to confine all operations within the repository and designated local configuration paths.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…encode-sync into feat/extra-config-sync
Summary
Introduce extraConfigPaths to sync extra configuration files and directories alongside secrets. This propagates through init, config normalization, sync planning, manifest handling, and apply logic, plus updates to tests and docs.
Changes