This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Added objects. Validate letters. Add distributions#10
Closed
peternijssen wants to merge 1 commit intoiMicknl:masterfrom
peternijssen:master
Closed
Added objects. Validate letters. Add distributions#10peternijssen wants to merge 1 commit intoiMicknl:masterfrom peternijssen:master
peternijssen wants to merge 1 commit intoiMicknl:masterfrom
peternijssen:master
Conversation
Contributor
Author
|
@iMicknl Any updates on code validation? I will run some final tests on my end. |
Owner
|
Sorry, I totally missed this PR... Will have a look today / tomorrow! Thanks for your contribution. |
Contributor
Author
|
No problem! I still have to look why it won't run locally. I believe it's a config error in my editor though. So I don't expect many more code changes. |
Contributor
Author
|
Closing this one in favor of #11 |
Owner
|
@peternijssen I will have a look at all changes this week, so we can get it published and create a new Home Assistant PR. |
iMicknl
pushed a commit
that referenced
this pull request
Aug 18, 2019
* Added objects. Validate letters. Add distributions * small fixes in package and letter, added relevant method and black formatted * refined classes, added to changelog and updated test_nl...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My enviroment is acting strange. Will have to check what's wrong, but perhaps meanwhile you can validate code. Thanks!