Integrated and extended @peternijssen version (#10)#11
Integrated and extended @peternijssen version (#10)#11iMicknl merged 4 commits intoiMicknl:masterfrom
Conversation
Added objects. Validate letters. Add distributions
eavanvalkenburg
changed the title
|
Awesome! You were capable of running the test local? I had issues with that, but they seem to be related to my environment. Just hadn't had the time yet to recheck. If you could rename the version to 1.2.0, then my MR can be closed and we can use this one. Would be great if we could tag this version afterwards, then I'll update the component in HA. |
|
Just made some further refinements and change the version to 1.2.0 |
There was a problem hiding this comment.
Nice work @peternijssen & @eavanvalkenburg! :-)
@eavanvalkenburg is this one ready to merge?
|
LGTM |
|
@iMicknl any chance of merging and tagging it soon? No pressure, but would love to update the HA component in the upcoming version. Thanks! |
|
@peternijssen I will merge and publish on monday. Thanks for the reminder. |
|
@peternijssen newest version has been published on PyPi. https://pypi.org/project/postnl-api/ |
3 participants
I integrated the work @peternijssen did for #10 I added a extra method get_relevant_deliveries and property methods in the classes, created new Readme with a new test script. And finally did Black formatting on the whole thing.
I also unified the method names, so get_... always as a plural so get_deliveries, get_letters, etc.