Test workflow: remove unused setting #2 #11276
Closed
+0
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
Contributor
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
sensei-hacker
added a commit
to sensei-hacker/inav_unofficial_targets
that referenced
this pull request
Jan 22, 2026
PROBLEM: PR iNavFlight#11276 modified blackboxConfig_s struct in blackbox.h without incrementing version in blackbox.c, and the workflow didn't catch it. ROOT CAUSE: Script processed files independently: - Checked blackbox.c → found PG_REGISTER but struct not in this file - Checked blackbox.h → found struct change but no PG_REGISTER - Never connected the two pieces together SOLUTION: 1. Expand file list to include companions that contain PG_REGISTER (if blackbox.h changed, also check blackbox.c for PG_REGISTER) 2. Search ALL changed files for struct definitions (when checking PG_REGISTER in blackbox.c, search all changed files including blackbox.h for the struct) 3. Detect when struct changed but PG_REGISTER wasn't touched (empty old_version and new_version → version not incremented) This correctly catches the most common bug: developer modifies struct in header file but forgets to increment version in source file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Remove unused
invertedCardDetectionsetting from blackbox configurationDelete related documentation and YAML configuration entries
Simplify blackbox config struct by removing obsolete field
Diagram Walkthrough
File Walkthrough
blackbox.c
Remove invertedCardDetection initializationsrc/main/blackbox/blackbox.c
invertedCardDetectionfield initialization fromPG_RESET_TEMPLATEmacroblackbox.h
Remove invertedCardDetection struct fieldsrc/main/blackbox/blackbox.h
uint8_t invertedCardDetectionfield fromblackboxConfig_stypedef
Settings.md
Remove sdcard_detect_inverted documentationdocs/Settings.md
sdcard_detect_invertedsetting documentation sectioninstructions
settings.yaml
Remove sdcard_detect_inverted YAML entrysrc/main/fc/settings.yaml
sdcard_detect_invertedsetting entry from blackboxconfiguration group