Add pinioBoxConfig_t to PG struct sizes reference database#11619
Merged
sensei-hacker merged 1 commit intoJun 4, 2026
Merged
Conversation
pinioBoxConfig_t was missing from the reference database despite SPEEDYBEEF745AIO having USE_PINIOBOX defined. The struct is uint8_t permanentId[PINIO_COUNT] (4 bytes), PG version 1.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pinioBoxConfig_twas missing fromcmake/pg_struct_sizes.reference.dbdespite the reference target (SPEEDYBEEF745AIO) havingUSE_PINIOandUSE_PINIOBOXdefined. It was simply omitted when the reference database was first generated.uint8_t permanentId[PINIO_COUNT]→ 4 bytesPG_REGISTER_WITH_RESET_TEMPLATE(..., PG_PINIOBOX_CONFIG, 1))pinioBoxConfig_thas been present in INAV for ~8 yearsChanges
cmake/pg_struct_sizes.reference.db: addpinioBoxConfig_t 4 1Test plan
USE_PINIOBOXintarget.h✓PINIO_COUNT = 4and PG version = 1 in source ✓validate-pg-for-release.shpasses after this change