Optical flow support#434
Conversation
There was a problem hiding this comment.
Perhaps deltaX and deltaY? Or a union of the two?
There was a problem hiding this comment.
A union is good. Will do.
|
Well this all looks pretty straightforward so far. The interesting task is, of course, "Add OpFlow support to position estimation code and navigation functions". And the soft SPI fixes are a bit hacky, but I guess we can live with that for the moment. |
|
You mean when doing delays? SoftSPI by itself is hacky 😄 Until we have a proper abstraction of Bus layer we'll probably have to live with hacky stuff. Yes, OpFlow navigation is gonna be a tough one, especially knowing that we need sonar to measure real altitude and calculate correct velocities. Lack of position data from OpFlow is also a problem, so estimated position will probably be locked to (0;0) w/o GPS, but velocity control will allow PosHold and CRUISE mode as well. |
There was a problem hiding this comment.
I think we should get into the habit of forward declarations in header files, eg
struct opflow_s;
bool opflowADNS3080Detect(struct opflow_s *opflow);
a80bbf5 to
f8854f7
Compare
|
Any good source of ADNS3080? |
|
Cool. Thanks! |
|
@digitalentity , can you rebase this? |
|
Sure. |
f8854f7 to
daa932c
Compare
|
@martinbudden rebased. I would appreciate if you would look at initialisation part of |
|
Hi guys! Is this still in progress? |
|
This is a very slo-mo task, sorry. Eventually we'll see opflow support, but probably not very soon. |
|
Wish I could help. I'll try to do a little research and maybe speed up the progress |
|
@digitalentity , can you rebase this. I know it's on hold at the moment, but I think it's a good idea to rebase it now otherwise rebasing will get increasingly difficult. |
42cd5ab to
b2b7955
Compare
41b10dc to
83f4a4a
Compare
83f4a4a to
a063c05
Compare
|
Could someone explain to me how far into the development we are? I see the check marks but I'm a little confused as to what needs to be done. Thanks! |
| #ifdef OPTICAL_FLOW | ||
| config->opflowConfig.opflow_hardware = OPTICAL_FLOW_AUTODETECT; | ||
| #else | ||
| config->opflowConfig.opflow_hardware = PITOT_NONE; |
There was a problem hiding this comment.
Typo, presumably this should not be PITOT_NONE.
|
OMG, after PGs are done this will be one hell of a rebase. |
|
@johnsilvester I've barely scratched the surface here. The hardware was detected and read properly (at least several rebases ago), but no actual sensor fusion is performed. |
|
@digitalentity Cool! Thanks for all of the progress so far! |
|
does this patch work?I want to use it |
|
@MengHaoyu no, it doesn't. I have this on low priority. |
|
ok,thanks,i bought an a3080 sensor, i thought i could use it 😬 |
|
Will be replace with new PR |
This is to discuss and review the code. @martinbudden I'd really apreaciate your comments and suggestions on this one.
Tasks to do: