Skip to content

Improved gyro initialisation#456

Merged
digitalentity merged 4 commits intoiNavFlight:masterfrom
martinbudden:inav_gyro_init
Aug 29, 2016
Merged

Improved gyro initialisation#456
digitalentity merged 4 commits intoiNavFlight:masterfrom
martinbudden:inav_gyro_init

Conversation

@martinbudden
Copy link
Copy Markdown
Contributor

No description provided.

@martinbudden martinbudden added this to the 1.2 milestone Aug 11, 2016
@martinbudden
Copy link
Copy Markdown
Contributor Author

@digitalentity , this is some further cleanup of the gyro initialisation which brings it into line with some changes I made in betaflight a while ago.

It doesn't directly address the memory problem, but I'd be interested to know if that problem still exists after these changes.

Comment thread src/main/sensors/acceleration.c Outdated
@@ -42,6 +42,7 @@
acc_t acc; // acc access functions
int32_t accADC[XYZ_AXIS_COUNT];
sensor_align_e accAlign = 0;
const uint32_t accTargetLooptime = 1000;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't assume acc is sampled at 1khz rate. it's sampled at the same rate as gyro at the moment.

@stronnag
Copy link
Copy Markdown
Collaborator

I tried this on top of master. It was unflyable with massive vibrations on 'roll' --- elvis on steroids.

Log file: http://seyrsnys.myzen.co.uk/inav-456/LOG00342.TXT
selection_484

@martinbudden
Copy link
Copy Markdown
Contributor Author

@stronnag , can you try this again when you get a chance?

There was a silly mistake in the filter initialisation which I have now fixed.

@stronnag
Copy link
Copy Markdown
Collaborator

Tested. Works, no unexpected behaviours. Has no effect on #431.

@digitalentity
Copy link
Copy Markdown
Member

@martinbudden can you address the merge conflict?

@martinbudden
Copy link
Copy Markdown
Contributor Author

@digitalentity , this is rebased and ready to merge now

@digitalentity digitalentity merged commit b45737d into iNavFlight:master Aug 29, 2016
@martinbudden martinbudden deleted the inav_gyro_init branch August 29, 2016 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants