Skip to content

FrSkyPilot target variation#6705

Merged
shellixyz merged 4 commits intoiNavFlight:masterfrom
MrD-RC:frskypilot_led-target
May 11, 2021
Merged

FrSkyPilot target variation#6705
shellixyz merged 4 commits intoiNavFlight:masterfrom
MrD-RC:frskypilot_led-target

Conversation

@MrD-RC
Copy link
Copy Markdown
Member

@MrD-RC MrD-RC commented Mar 12, 2021

I have added a new target variation for the FrSky Pilot flight controllers. This adds LED support on Ch10. PWM only Ch1-9 with this target. UART 3 on Ch 11 & 12.

Just to clarify, this is not a new target, it is based on and existing target.

I have added a new target for the FrSky Pilot flight controllers. This adds LED support on Ch10. PWM only Ch1-9 with this target.
@MrD-RC
Copy link
Copy Markdown
Member Author

MrD-RC commented Mar 12, 2021

@MrD-RC
Copy link
Copy Markdown
Member Author

MrD-RC commented Mar 12, 2021

Added documentation file

@DzikuVx
Copy link
Copy Markdown
Member

DzikuVx commented Mar 12, 2021

@MrD-RC
Copy link
Copy Markdown
Member Author

MrD-RC commented Mar 12, 2021

@DzikuVx All 3 of those new target requirements would have been met when the original target created. Surely to submit a simple variant like this, I shouldn’t be required to buy and provide flight controllers for two core developers?

I can understand that policy for new targets, but this just adds a feature to an existing target and literally took 5 minutes. Surely the open source ethos should exist when it comes to modifying existing targets. If someone can add an improvement or change that benefits the community, it should be ok?

I think the target variants procedure and requirements needs to be clarified. I can understand the need to not to have too many targets too. But this would only be the 1st variant for this target, when other boards have 3 already. Also, perhaps configurator can be improved to make finding targets easier?

@digitalentity could we please get your opinion on this?

@MrD-RC MrD-RC changed the title New FrSkyPilot target New FrSkyPilot target variation Mar 12, 2021
@MrD-RC MrD-RC changed the title New FrSkyPilot target variation FrSkyPilot target variation Mar 12, 2021
@shellixyz
Copy link
Copy Markdown
Collaborator

@MrD-RC Don't worry, you don't have to provide boards. Pawel thought none of the devs had any of these but it is not the case

Copy link
Copy Markdown
Collaborator

@shellixyz shellixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shellixyz shellixyz merged commit fac79ee into iNavFlight:master May 11, 2021
@shellixyz shellixyz added this to the 3.0 milestone May 11, 2021
@MrD-RC MrD-RC deleted the frskypilot_led-target branch May 11, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants