fix(plugin): set modrinth_id for publishMods - #8
Merged
Conversation
The plugin is a standalone Gradle build and reads plugin/gradle.properties, not the
root one, so providers.gradleProperty("modrinth_id") was empty and publishModrinth
failed: 'platform.projectId doesn't have a configured value'. Set the (public) id
Ff3Cg2wn — same Modrinth project as the mod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin is a standalone Gradle build so it reads
plugin/gradle.properties, not the root one —modrinth_idwas still commented there, so./gradlew -p plugin publishModsfailed withplatform.projectId doesn't have a configured value. Set the (public, same-project) idFf3Cg2wn.After merging, re-run the release. Tip: do a
dryRunfirst before a real multi-loader publish (a mid-run failure leaves a partial release).