Remove option to run as threaded execution#23
Merged
Merged
Conversation
jomey
added
the
maintenance
Member
Author
|
Note that this should be reviewed after #22 I did not test how the new HRRR Thermal would work with this option. Since no current installation uses this (to the best of my knowledge), I opted to remove this all together. |
jomey
added a commit
to iSnobal/model_setup
that referenced
this pull request
Oct 1, 2025
This has been removed from SMRF: iSnobal/smrf#23
This was an unused and recently untested configuration. Going forward, all variables are distributed in serial manner to ensure dependent values are available when calculating individual forcings.
Also update the description and example in the header of the file.
More to be added.
jomey
added a commit
to iSnobal/awsm
that referenced
this pull request
Oct 2, 2025
The thread option was removed from SMRF in (iSnobal/smrf#23 This is a follow up clean up to remove this option when running through AWSM. This also removes the unused `smrf_ipysnobal` option, which partly used threaded too making for a streamlined execution logic.
The thread feature has been removed.
arobledano
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13