Skip to content

Conversation

@skripchenkoVeta
Copy link
Contributor

No description provided.

add hello world script
@skripchenkoVeta skripchenkoVeta changed the base branch from main to rubylab-2021-2022 November 4, 2021 23:07
@skripchenkoVeta skripchenkoVeta marked this pull request as draft November 4, 2021 23:11
@skripchenkoVeta skripchenkoVeta marked this pull request as ready for review November 4, 2021 23:11
@skripchenkoVeta
Copy link
Contributor Author

I need help. unfortunately I can't add reviews to my PR

@jtethras jtethras self-requested a review November 5, 2021 10:02
Copy link

@jtethras jtethras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Recommendation: please also add empty line at the end of file

Reasons:
https://stackoverflow.com/questions/2287967/why-is-it-recommended-to-have-empty-line-in-the-end-of-a-source-file

UPD: my bad, forgot git does not display the empty line at EOF. All good!

@NastassiaBon NastassiaBon mentioned this pull request Nov 8, 2021
@skripchenkoVeta skripchenkoVeta merged commit 5aef25b into iTechArt-RubyLab:rubylab-2021-2022 Nov 8, 2021
GEK62 pushed a commit to GEK62/Ruby-Lab that referenced this pull request Nov 12, 2021
Bump rubocop version

Local run fix

Add description for hometask iTechArt-RubyLab#2 (iTechArt-RubyLab#24)

Created AndrewTehan/hometask-1 dir and hello_world.rb (iTechArt-RubyLab#21)

first commit (iTechArt-RubyLab#22)

Pivovar Andrew/hometask 1 (iTechArt-RubyLab#13)

* Create helloworld.rb

* Update helloworld.rb

* Update helloworld.rb

* Update helloworld.rb

* Update helloworld.rb

PandaGrom hometask 1 (iTechArt-RubyLab#5)

* create hello_world.rb

* fix hound issues

* make hello_world.rb file executable

Gek62 hometask 1 (iTechArt-RubyLab#12)

* First init

* Local run fix

trueananas17/hometask-1 (iTechArt-RubyLab#34)

* Create hello_world.rb

* Update hello_world.rb

* Update hello_world.rb

* Update hello_world.rb

* move # !/usr/bin/env ruby to the upper line

HOMETASK-1/init-project (iTechArt-RubyLab#23)

add hello world script

Valeriyapetrova/hometask 1 (iTechArt-RubyLab#31)

homework_1 (iTechArt-RubyLab#25)

* dz1

Co-authored-by: Roma Dunovskiy <romyashi@MacBook-Air-Roma.local>

alhimick-prog hometask 1 (iTechArt-RubyLab#20)

* first_hometask

* fix_final_newline_frozen_string_literal

Mlshvch hometask 1 (iTechArt-RubyLab#18)

* Create hello_world.rb file

* Make hello_world.rb file executable

* Fix Hound violations

hometask_1 (iTechArt-RubyLab#15)

PandaGrom hometask 2 (iTechArt-RubyLab#30)

* Complete hometask 2

* fix defect

Complete hometask-1 (iTechArt-RubyLab#6)

Complete hometask 2 (iTechArt-RubyLab#38)

Add description for hometask iTechArt-RubyLab#3 (iTechArt-RubyLab#45)

Silitski/hometask1 (iTechArt-RubyLab#47)

Hometask-1. Add hello_world.rb (iTechArt-RubyLab#49)

hometask-1 (iTechArt-RubyLab#43)

* hometask-1

* Refactor code

* Refactor code 2

* Add env ruby

add first task (iTechArt-RubyLab#41)

* add firts task

* move hometask folder into anastasi-ivl

* Update hello_world.rb

* Added empty line after magic lines

* hello_world.rb executable

Hometask 2 upload

run_cli fix
qqqwww123cdv pushed a commit to qqqwww123cdv/Ruby-Lab that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants