Skip to content

hometask-1 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2021
Merged

hometask-1 #43

merged 5 commits into from
Nov 8, 2021

Conversation

@NastassiaBon
Copy link
Contributor

No description provided.

@Kaddyluck
Copy link

  1. File isn't executable
    image
  2. Please leave more clear comments.
    What is it "Refactor code", "Refactore code 2"? What did you do in these commits? I don't know until I'll open them. Remember: "Use the body to explain what and why vs. how".
    So better names will be: "Added frozen string literal comment", "Added blank line"
  3. Run RoboCop locally before pushing, it will help not to spam one-line commits with Hound fixes

@NastassiaBon NastassiaBon force-pushed the NatassiaBon-HomeWork1 branch from d96ec1a to d4d4733 Compare November 8, 2021 08:51
ramantechart
ramantechart previously requested changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@ramantechart ramantechart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync fork with original repo

@NastassiaBon
Copy link
Contributor Author 

1. **File isn't executable**
   ![image](https://user-images.githubusercontent.com/11877985/140704149-983a2ff1-71c1-46a0-9b8d-0e288cb4f77f.png)

2. Please leave more clear comments.
   What is it "Refactor code", "Refactore code 2"? What did you do in these commits? I don't know until I'll open them. Remember: "Use the body to explain **what** and **why** vs. **how**".
   So better names will be: "Added frozen string literal comment", "Added blank line"

3. Run RoboCop locally before pushing, it will help not to spam one-line commits with Hound fixes
  1. I make executable file, but unfortunately i have hound linter issue i cant understand why because my code the same with my colleague. Skripchenkoveta hometask 1 #23
  2. I rewrite commit history and i m going to use right naming conversion in future. should i add "Refactor commit" in this tasks?
  3. Done

@ramantechart
Copy link
Contributor

@NastassiaBon I'm pretty much sure just syncing the fork with the main repository will be more then enough

@Kaddyluck
Copy link

  1. Check Roman's comment
  2. Ok. Not necessary, leave it as it is in that PR

@Kaddyluck Kaddyluck self-requested a review November 8, 2021 20:28
@NastassiaBon NastassiaBon force-pushed the NatassiaBon-HomeWork1 branch from d4d4733 to 5f2ed10 Compare November 8, 2021 20:43
@Kaddyluck Kaddyluck merged commit 3fa74dc into iTechArt-RubyLab:rubylab-2021-2022 Nov 8, 2021
GEK62 pushed a commit to GEK62/Ruby-Lab that referenced this pull request Nov 12, 2021
@ramantechart @GEK62
Fail Github PR check on Hound violations
90e4489 
Bump rubocop version

Local run fix

Add description for hometask iTechArt-RubyLab#2 (iTechArt-RubyLab#24)

Created AndrewTehan/hometask-1 dir and hello_world.rb (iTechArt-RubyLab#21)

first commit (iTechArt-RubyLab#22)

Pivovar Andrew/hometask 1 (iTechArt-RubyLab#13)

* Create helloworld.rb

* Update helloworld.rb

* Update helloworld.rb

* Update helloworld.rb

* Update helloworld.rb

PandaGrom hometask 1 (iTechArt-RubyLab#5)

* create hello_world.rb

* fix hound issues

* make hello_world.rb file executable

Gek62 hometask 1 (iTechArt-RubyLab#12)

* First init

* Local run fix

trueananas17/hometask-1 (iTechArt-RubyLab#34)

* Create hello_world.rb

* Update hello_world.rb

* Update hello_world.rb

* Update hello_world.rb

* move # !/usr/bin/env ruby to the upper line

HOMETASK-1/init-project (iTechArt-RubyLab#23)

add hello world script

Valeriyapetrova/hometask 1 (iTechArt-RubyLab#31)

homework_1 (iTechArt-RubyLab#25)

* dz1

Co-authored-by: Roma Dunovskiy <romyashi@MacBook-Air-Roma.local>

alhimick-prog hometask 1 (iTechArt-RubyLab#20)

* first_hometask

* fix_final_newline_frozen_string_literal

Mlshvch hometask 1 (iTechArt-RubyLab#18)

* Create hello_world.rb file

* Make hello_world.rb file executable

* Fix Hound violations

hometask_1 (iTechArt-RubyLab#15)

PandaGrom hometask 2 (iTechArt-RubyLab#30)

* Complete hometask 2

* fix defect

Complete hometask-1 (iTechArt-RubyLab#6)

Complete hometask 2 (iTechArt-RubyLab#38)

Add description for hometask iTechArt-RubyLab#3 (iTechArt-RubyLab#45)

Silitski/hometask1 (iTechArt-RubyLab#47)

Hometask-1. Add hello_world.rb (iTechArt-RubyLab#49)

hometask-1 (iTechArt-RubyLab#43)

* hometask-1

* Refactor code

* Refactor code 2

* Add env ruby

add first task (iTechArt-RubyLab#41)

* add firts task

* move hometask folder into anastasi-ivl

* Update hello_world.rb

* Added empty line after magic lines

* hello_world.rb executable

Hometask 2 upload

run_cli fix
qqqwww123cdv pushed a commit to qqqwww123cdv/Ruby-Lab that referenced this pull request Nov 16, 2021
@NastassiaBon
hometask-1 (iTechArt-RubyLab#43)
05c8be6 
* hometask-1

* Refactor code

* Refactor code 2

* Add env ruby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Kaddyluck Kaddyluck Kaddyluck approved these changes

@ramantechart ramantechart ramantechart left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NastassiaBon @Kaddyluck @ramantechart