PandaGrom hometask 2 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieisnuje
reviewed
Nov 8, 2021
| break if str == 'exit!' | ||
|
|
||
| if str.empty? | ||
| p 'String can not be blank!' |
There was a problem hiding this comment.
You used print in line 11 and now you are using p
Use the same method here to make your code consistent
nieisnuje
reviewed
Nov 8, 2021
| if str.empty? | ||
| p 'String can not be blank!' | ||
| else | ||
| p "Middle character: #{get_middle(str)}" |
nieisnuje
approved these changes
Nov 8, 2021
GEK62
pushed a commit
to GEK62/Ruby-Lab
that referenced
this pull request
Nov 12, 2021
Bump rubocop version Local run fix Add description for hometask iTechArt-RubyLab#2 (iTechArt-RubyLab#24) Created AndrewTehan/hometask-1 dir and hello_world.rb (iTechArt-RubyLab#21) first commit (iTechArt-RubyLab#22) Pivovar Andrew/hometask 1 (iTechArt-RubyLab#13) * Create helloworld.rb * Update helloworld.rb * Update helloworld.rb * Update helloworld.rb * Update helloworld.rb PandaGrom hometask 1 (iTechArt-RubyLab#5) * create hello_world.rb * fix hound issues * make hello_world.rb file executable Gek62 hometask 1 (iTechArt-RubyLab#12) * First init * Local run fix trueananas17/hometask-1 (iTechArt-RubyLab#34) * Create hello_world.rb * Update hello_world.rb * Update hello_world.rb * Update hello_world.rb * move # !/usr/bin/env ruby to the upper line HOMETASK-1/init-project (iTechArt-RubyLab#23) add hello world script Valeriyapetrova/hometask 1 (iTechArt-RubyLab#31) homework_1 (iTechArt-RubyLab#25) * dz1 Co-authored-by: Roma Dunovskiy <romyashi@MacBook-Air-Roma.local> alhimick-prog hometask 1 (iTechArt-RubyLab#20) * first_hometask * fix_final_newline_frozen_string_literal Mlshvch hometask 1 (iTechArt-RubyLab#18) * Create hello_world.rb file * Make hello_world.rb file executable * Fix Hound violations hometask_1 (iTechArt-RubyLab#15) PandaGrom hometask 2 (iTechArt-RubyLab#30) * Complete hometask 2 * fix defect Complete hometask-1 (iTechArt-RubyLab#6) Complete hometask 2 (iTechArt-RubyLab#38) Add description for hometask iTechArt-RubyLab#3 (iTechArt-RubyLab#45) Silitski/hometask1 (iTechArt-RubyLab#47) Hometask-1. Add hello_world.rb (iTechArt-RubyLab#49) hometask-1 (iTechArt-RubyLab#43) * hometask-1 * Refactor code * Refactor code 2 * Add env ruby add first task (iTechArt-RubyLab#41) * add firts task * move hometask folder into anastasi-ivl * Update hello_world.rb * Added empty line after magic lines * hello_world.rb executable Hometask 2 upload run_cli fix
qqqwww123cdv
pushed a commit
to qqqwww123cdv/Ruby-Lab
that referenced
this pull request
Nov 16, 2021
* Complete hometask 2 * fix defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete hometask 2