Make command palette reachable from every screen - #10
Merged
Conversation
check_action's per-screen carve-outs (Dashboard, Device Tree, fullscreen graph, any other pushed screen) never included command_palette, so Ctrl+P silently did nothing outside the base List screen. Dashboard and List are both primary displays a user switches between via the palette. Refs #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HACLI.check_action's per-screen carve-outs (Dashboard, Device Tree, fullscreen graph, any other pushed screen) never allowedcommand_palettethrough, so Ctrl+P silently did nothing outside the base List screencommand_paletteto always returnTruebefore the carve-outs run, so the palette (Lists/Dashboard/Configuration/Setup wizard) is reachable from anywhere — Dashboard and List are both primary displays a user switches between via the palette, not a base view with secondary screens bolted onTest plan
tests/test_command_palette_availability.py: Ctrl+P opens the palette from Dashboard, Device Tree, the fullscreen graph, and a generic pushed screen (ConfigScreen)pytestsuite (1087 passed)ruff check .anduv run pyrightclean