Fix activity log entity scoping - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HAClient.fetch_logbooksending the entity filter asentity_idinstead of theentityparam HA's logbook REST endpoint actually reads — every log query was silently unrestricted, returning the whole instance's history instead of the requested entities. (🐛 Activity log ignores its entity filter (wrong HA query param) #13)a/A/iactivity/device log actions to the graphed entity (plus+comparison lines) when the inline graph panel is open, instead of falling back to the active list/table selection. (🐛 Opening the activity log from a graph loses the graphed entity's scope #14)Test plan
uv run pytest— full suite (1099 passed)uv run ruff check .uv run pyrightentityquery param infetch_logbooka/A/i(single entity, comparison lines, device expansion)Closes #13, Closes #14