Improve the graph help dialog (issue #7) - #8
Merged
Merged
Conversation
…eens Filters meaningless DataTable rows (Cursor left/right, Select, Home, End) from the live Main help page, and wires ? into Light Control, Media Player, Weather Forecast and Config screens — the first two are modals the app-level binding never reached, the latter two silently fell back to the unrelated Main page. Refs #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
left/right/shift+left/shift+right/home/end/enter/escape/q) into mode-accurate twin bindings, so the Footer and help page always describe what a key does right now instead of always showing the paging meaning while in inspect mode.n/Nsearch,L,u/ctrl+r) the issue called out, while keeping the ones that still work (d,D,s,T, quit).Cursor left/right,Select, bareHome/End) off the live Main help page.?into Light Control, Media Player, Weather Forecast and Config screens, which previously either didn't respond (modal screens) or silently fell back to the unrelated Main page.Test plan
test_graph.py,test_graph_cursor_stride.py,test_binary_graph.py,test_climate_graph.py,test_help.py,test_dashboard_*,test_device_tree.py,test_light_control.py,test_media_player_control.py,test_config_screen_*.py,test_entity_control.py)uv run ruff check .uv run pyrightpytestsuite (1083 passed)Refs #7
https://claude.ai/code/session_01KSut7AwCYk11MxgbVaxwc9