Media-path subscribe errors must not fail the session; clear stale dock errors - #171
Merged
Conversation
…rrors A video_subscribe_failed event fell through to the generic error tail, which calls on_join_failed - so one media-path error flipped a healthy in-meeting session to "Connection failed". Sources persist their participant binding but Zoom mints user ids per join, so after a rejoin the saved id often refers to nobody and every recovery retry raised another error dialog. Video subscribe failures are now media-path errors like shm_create_failed: if the bound participant is absent from the roster this is a waiting state (log only, recovery keeps retrying quietly until they appear); if present the error stays loud. Either way the meeting state and reconnect machinery are untouched. A successful join also clears last_error so the dock stops showing a dead attempt's failure over a live meeting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two operator-facing fixes found in live testing:
video_subscribe_failedfell through to the generic error tail and invoked the join-failure/reconnect machinery, flipping a healthy in-meeting session to "Connection failed". It is now handled as a media-path error. When the bound participant is not in the roster (stale id persisted in source settings — Zoom mints user ids per join) it is a quiet waiting state with the recovery loop retrying; when the participant is present the error stays loud. Meeting state is never touched.last_error, so the dock no longer shows a previous attempt's failure banner over a live meeting.🤖 Generated with Claude Code