Fix vacuously-green Windows CI and empty OBS import libraries - #175
Merged
Conversation
A runner-image update broke two text-scraping steps at once, and both failed soft: - The Zoom SDK draft-asset lookup (gh api --jq with embedded \" escapes) started splitting into multiple arguments. build.yml treated the failure as "no SDK" and went green while never compiling the plugin at all - CI has been vacuously passing on Windows since the image rolled. - dumpbin's export listing no longer matches the parsing regex, so lib.exe built EMPTY import libraries and the first real link failed with every obs_* symbol unresolved. Filter the releases JSON in PowerShell (as release-windows.yml now does), read PE export tables with pefile instead of scraping dumpbin, resolve the SDK directory by locating h/zoom_sdk.h rather than trusting archive nesting, and fail LOUDLY on every step that used to degrade silently: empty export lists, lib.exe errors, missing SDK layout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two runner-image casualties, both failing soft:
gh api --jqSDK lookup broke ("accepts 1 arg(s), received 3"), which build.yml treated as "no SDK available" — so Windows CI has been green without ever compiling the plugin. Same PowerShell-side JSON filtering fix as Fix Windows release SDK lookup broken by runner PowerShell quoting change #174, now applied to CI.pefile, with a hard failure below 10 exports, onlib.exeerrors, and whenh/zoom_sdk.hcan't be located in the SDK archive.🤖 Generated with Claude Code