True stereo raw audio when the sender provides it - #177
Merged
Conversation
…urces Raw audio has been mono because nothing ever asked otherwise: isAudioRawDataStereo on the join parameters defaults to mono. Set it on both engines - stereo senders (Original Sound with stereo) now arrive as two real channels and mono senders arrive duplicated by the SDK itself. The consumers already keyed everything off the frame header's channel count; the only missing piece was a mono-preference source receiving a 2-channel wire, which now averages the pair instead of silently going stereo. The stereo option's label no longer claims to be a duplicate of mono. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
isAudioRawDataStereoon the join parameters of both engines (the SDK default is mono, which is why every session loggedchannels:1). Stereo senders now arrive as two real channels; mono senders are duplicated to both by the SDK. All consumers already honor the frame header's channel count end to end — the one gap was a mono-preference source on a 2-channel wire, which now downmixes by averaging instead of silently outputting stereo. Labels updated: "Stereo (true stereo when the sender provides it)".🤖 Generated with Claude Code