Fix Zoom audio pacing and responsive meters - #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Zoom supplies raw audio in 10 ms packets while the CoreVideo program mixer runs on a 20 ms tick. Sending whatever was available allowed partial blocks to reach Program, producing audible artifacts and weakening audio/video sync. Separately, the mixer used fixed-height meter segments, so taller windows created unused space while the dB scale continued to grow.
Operator impact
Zoom ISO and meeting-mix audio now enter Program in complete 20 ms blocks with a stable timing cushion. The mixer meters now scale with compact and maximized layouts instead of remaining pinned to a fixed height.
Validation
ctest -C Release --test-dir native/build-dev --output-on-failure— passeddotnet test native-shell/CoreVideoPro.WinUI.Tests/CoreVideoPro.WinUI.Tests.csproj -c Debug --no-restore— 710 passednpm run pack:native— passed; packaged native-core hash matched the validated buildA fresh real-meeting soak remains appropriate before promoting the alpha.