[DIAGNOSTIC] Register TimeContext for setup-experience suite - #197
Closed
micszo wants to merge 1 commit into
Closed
Conversation
Companion to ibexa/page-builder#592 (diagnostic/session-race-setup-feature-delay). setup-experience's own path list already includes vendor/ibexa/page-builder/features/setup/setup.feature, which that PR adds an "I wait ... seconds" step to. Without TimeContext registered here too, that step is undefined for this suite, which made every non-matcher job in ibexa/experience#615 fail on an unrelated "undefined step" error instead of actually exercising the diagnostic. Not a proposed permanent change - purely so the delay diagnostic in page-builder#592 can run cleanly across every suite that shares that feature file, not just the page-builder suite itself. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
micszo
added a commit
to ibexa/experience
that referenced
this pull request
Aug 28, 2026
Companion to the ibexa/page-builder diagnostic branch already listed here. ibexa/behat#197 registers TimeContext for the setup-experience suite, which is needed for page-builder#592's wait step to run cleanly on the non-matcher jobs too (they use setup-experience, not the page-builder suite, but share the same setup.feature file). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to ibexa/page-builder#592 (diagnostic, not a proposed fix)
page-builder#592is a draft diagnostic testing whether a session write/read race explains the "Add first/second test catalog for Catalog block" failures on ibexa/experience's siteaccess-matcher CI shards since Symfony 7.4.17. It adds anAnd I wait "..." secondsstep tovendor/ibexa/page-builder/features/setup/setup.feature.This repo's
setup-experiencesuite (behat_ibexa_experience.yaml) already lists that same feature file in its ownpaths, but doesn't haveIbexa\Behat\Core\Context\TimeContextin itscontexts. Running the diagnostic without this change made that step undefined forsetup-experience, which failed every non-matcher job in a regression run (ibexa/experience#615) on an unrelated error instead of actually testing the hypothesis.This just wires
TimeContextintosetup-experienceso the diagnostic can run cleanly everywhere that shares the feature file. Not proposing this as a permanent addition on its own — it only matters whilepage-builder#592's wait step exists.🤖 Generated with Claude Code