Mark higher-level nodes with "New" pill as well, not only the actual item #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
changed the title
mnocon
force-pushed
the
propagate-new-pill
branch
from
1664190 to
ba1393b
Compare
mnocon
force-pushed
the
propagate-new-pill
branch
from
ba1393b to
342b8dc
Compare
dew326
approved these changes
Jul 10, 2024
Co-authored-by: Dariusz Szut <dew326@gmail.com>
julitafalcondusza
approved these changes
Jul 11, 2024
juskora
approved these changes
Jul 12, 2024
adriendupuis
approved these changes
Jul 12, 2024
Contributor
adriendupuis
left a comment
adriendupuis
left a comment
There was a problem hiding this comment.
A protection against duplicate seems useless but no performance issue if kept.
Nice trick to have the pill hidden on every node and reveal the one from new leafs' ancestors.
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jul 15, 2024
…item (#2429) * Mark higher-level nodes with "New pill", not only the actual item * Before review * Update docs/js/custom.js Co-authored-by: Dariusz Szut <dew326@gmail.com> * Applied review suggestion Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> --------- Co-authored-by: Dariusz Szut <dew326@gmail.com> Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #2394
Target: master, 4.6
When compiling the changelog I've noticed that while the New pill is great it's not so easy to notice when it's hidden deep in the tree. If you go to https://doc.ibexa.co/en/latest/ it's hard to find that we've added a page for the ContentName criterion. You also don't learn that Ibexa Engage is new unless you decide to expand this section.
This PR propagates the "New" pill to higher nodes - if there is a child node with a "New" label the parent node will display "New" as well.
Preview: https://ez-systems-developer-documentation--2429.com.readthedocs.build/en/2429/
I'm finding the visible pills -> then finding their parents in the DOM -> then finding the closest pill to each parent -> making them visible
My JS skills are very basic, maybe there's a better way to do this - all suggestions are welcome.