Skip to content

Mark higher-level nodes with "New" pill as well, not only the actual item #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Mark higher-level nodes with "New" pill as well, not only the actual item #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c8be42
Mark higher-level nodes with "New pill", not only the actual item
mnocon Jul 9, 2024
342b8dc
Before review
mnocon Jul 9, 2024
76be70b
Update docs/js/custom.js
mnocon Jul 10, 2024
bb60242
Applied review suggestion
mnocon Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/js/custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,4 +202,7 @@ $(document).ready(function() {
closeBtn.closest('.notification').setAttribute('hidden', 'hidden');
});
});

// Mark higher-level nodes with "New" pill, not only the actual item
$(".pill.new:not([hidden])").parents(".md-nav__item").children('label').children(".pill.new[hidden]").removeAttr('hidden');
});
2 changes: 1 addition & 1 deletion theme/partials/nav-item.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{% set checked = "checked" if nav_item.active %}
<input class="md-nav__toggle md-toggle" data-md-toggle="{{ path }}" type="checkbox" id="{{ path }}" {{ checked }}>
<label class="md-nav__link level-{{ level }}" for="{{ path }}">
{{ nav_item.title }}
{{ nav_item.title }} <span class="pill new" hidden>New</span>
</label>
<nav class="md-nav" aria-label="{{ nav_item.title }}" data-md-level="{{ level }}">
<label class="md-nav__link-title md-nav__link level-{{ level }}" for="{{ path }}">
Expand Down