Skip to content

IBX-11774: Changed location into locale in user settings flash message - #133

Merged
barw4 merged 2 commits into
4.6from
ibx-11774
Aug 5, 2026
Merged

IBX-11774: Changed location into locale in user settings flash message#133
barw4 merged 2 commits into
4.6from
ibx-11774

Conversation

@barw4

@barw4 barw4 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-11774

Related PRs:

#124

Description:

The solution seems hacky, but a 'proper' solution is changing location identifier in different areas - services, route, maybe it does make sense to do it in v6.0 but I'm not sure about 4.6 and 5.0 due to BC.

For QA:

Documentation:

@barw4 barw4 self-assigned this Aug 4, 2026
@barw4 barw4 added Bug Something isn't working Ready for review labels Aug 4, 2026
@barw4 barw4 added Improvement Ready for review and removed Ready for review Bug Something isn't working labels Aug 4, 2026
@barw4
barw4 requested a review from a team August 4, 2026 08:41
@barw4
barw4 marked this pull request as ready for review August 4, 2026 08:41

@konradoboza konradoboza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough concerning avoiding BC break. Agreed that the breaking change (as in #134) will be applied on merge up to 6.0 alongside doc mention.

Comment thread src/bundle/Controller/UserSettingsController.php
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@barbaragr barbaragr self-assigned this Aug 4, 2026
@barw4
barw4 merged commit 8b60c76 into 4.6 Aug 5, 2026
14 checks passed
@barw4
barw4 deleted the ibx-11774 branch August 5, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants