IBX-3201: Added invitation email validation - #46
Merged
Conversation
ViniTou
changed the title
ViniTou
force-pushed
the
ibx-3201-added-email-validation
branch
2 times, most recently
from
July 27, 2022 07:30
d45f482 to
034be57
Compare
mikadamczyk
reviewed
Jul 27, 2022
mikadamczyk
reviewed
Jul 27, 2022
mikadamczyk
reviewed
Jul 27, 2022
ViniTou
force-pushed
the
ibx-3201-added-email-validation
branch
from
July 27, 2022 07:52
034be57 to
516f9e9
Compare
mikadamczyk
approved these changes
Jul 27, 2022
konradoboza
reviewed
Jul 27, 2022
| public static function getTranslationMessages() | ||
| { | ||
| return [ | ||
| Message::create('ibexa.user.invitation.user_with_email_exists', 'validators') |
Contributor
There was a problem hiding this comment.
Suggested change
| Message::create('ibexa.user.invitation.user_with_email_exists', 'validators') | |
| Message::create($message, 'validators') |
Contributor
Author
There was a problem hiding this comment.
That's not gonna work, I would have to create property & private const, and that's just seems to much.
| * Checks if the passed value is valid. | ||
| * | ||
| * @param string $email The value that should be validated | ||
| * @param \Symfony\Component\Validator\Constraint $constraint The constraint for the validation |
Contributor
There was a problem hiding this comment.
Suggested change
| * @param \Symfony\Component\Validator\Constraint $constraint The constraint for the validation |
Doesn't seem to bring much value.
| } | ||
|
|
||
| /** | ||
| * Checks if the passed value is valid. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Checks if the passed value is valid. |
It seems pretty self-explanatory.
|
Kudos, SonarCloud Quality Gate passed!
|
webhdx
approved these changes
Jul 28, 2022
mnocon
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.ibexa.co/browse/IBX-3201
https://issues.ibexa.co/browse/IBX-3361