Skip to content

Conversation

@evansiroky
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)
  • Code coverage does not significantly worsen (ideally it improves) (remove this if not merging to master)

Description

We haven't made a release for too long and when we tried to do so back in February, complications occurred, so a release wasn't actually produced. Let's try again once #488 is merged into dev.

evansiroky and others added 30 commits March 21, 2019 14:02
Bump Bootstrap to fix xss vulnerability
- add more comments
- only fetch users after update if the user being updated was not the current user
Make sure the status message is cleared when updating users
this is needed to make sure snapshots with time elements work on computers with different timezone settings
Prevent an infinite loop when sorting trips
@evansiroky evansiroky changed the title New release Next release Sep 24, 2019
Mege in master branch from catalogueglobal which has all the tags.
@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

Merging #490 into master will increase coverage by 38.4%.
The diff coverage is 46.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage     5.3%   43.71%   +38.4%     
==========================================
  Files         322      309      -13     
  Lines       15456    16424     +968     
  Branches     4655     5032     +377     
==========================================
+ Hits          820     7179    +6359     
+ Misses      12495     8083    -4412     
+ Partials     2141     1162     -979
Flag Coverage Δ
#end_to_end_tests 44.65% <44.34%> (?)
#unit_tests 16.28% <27.38%> (?)
Impacted Files Coverage Δ
lib/editor/containers/ActiveTripPatternList.js 56.66% <ø> (+56.66%) ⬆️
...manager/components/version/FeedVersionNavigator.js 55% <ø> (+55%) ⬆️
lib/manager/components/ProjectSettings.js 86.95% <ø> (+86.95%) ⬆️
lib/manager/selectors/index.js 69.88% <ø> (-1.28%) ⬇️
lib/manager/util/index.js 88.19% <ø> (+86.23%) ⬆️
lib/alerts/containers/ActiveAlertEditor.js 23.07% <ø> (+23.07%) ⬆️
lib/types/index.js 0% <ø> (ø) ⬆️
lib/public/components/UserAccount.js 0% <ø> (ø) ⬆️
lib/manager/util/version.js 76.74% <ø> (+76.74%) ⬆️
lib/common/components/ManagerPage.js 83.33% <ø> (+83.33%) ⬆️
... and 412 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff095d...8ac42ef. Read the comment docs.

@landonreed landonreed assigned evansiroky and unassigned landonreed Oct 2, 2019
@landonreed
Copy link
Contributor

Looks like e2e may be broken?

Remove eTID; filter permissions on module
Copy link
Contributor

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not.

Hold on to your butts

@landonreed landonreed merged commit 4293884 into master Oct 4, 2019
@landonreed
Copy link
Contributor

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants