Updates ready for MQ V9.0.4 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parrobe
reviewed
Nov 1, 2017
| ## Prerequisites | ||
|
|
||
| - Kubernetes 1.7 or greater, with beta APIs enabled | ||
| - Kubernetes 1.6 or greater, with beta APIs enabled |
Member
There was a problem hiding this comment.
Lowered the Kubernetes requirement?
parrobe
reviewed
Nov 1, 2017
| spec: | ||
| serviceName: {{ .Values.service.name }} | ||
| replicas: 1 | ||
| {{- if and (ge (.Capabilities.KubeVersion.Major | int) 1) (ge (.Capabilities.KubeVersion.Minor | int) 7) }} |
Member
There was a problem hiding this comment.
This looks like a check to make sure the Kube version has a minor of 1.7 but the above line in the readme says 1.6 now.
| ## Prerequisites | ||
|
|
||
| - Kubernetes 1.7 or greater, with beta APIs enabled | ||
| - Kubernetes 1.6 or greater, with beta APIs enabled |
| spec: | ||
| serviceName: {{ .Values.service.name }} | ||
| replicas: 1 | ||
| {{- if and (ge (.Capabilities.KubeVersion.Major | int) 1) (ge (.Capabilities.KubeVersion.Minor | int) 7) }} |
| func TestHelmStorageClass(t *testing.T) { | ||
| cs := kubeLogin(t) | ||
| release := strings.ToLower(t.Name()) | ||
| assertKubeVersion(t, cs, 1, 6) |
Member
There was a problem hiding this comment.
Looks for 1.6 here but a different check looks for 1.7?
Member
Author
|
That's the point. It only does the rolling update if the version is 1.7 or greater. Thus allowing the chart to work on Kubernetes 1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl,ca-certificates, and their dependencies, which were only used at build time