Fix POWER and z/Linux builds #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parrobe
approved these changes
Mar 5, 2019
parrobe
suggested changes
Mar 5, 2019
Member
parrobe
left a comment
parrobe
left a comment
There was a problem hiding this comment.
I can't add an in-line but the make targets for build-devserver and build-advancedserver need to call build-golang-sdk-ex not build-golang-sdk. It's because if you can the non-ex version of it for some reason make decides to try and download the sdk file a second time which if we're overriding can cause the file to be replaced with a HTTP error file.
| $(DOCKER) build -t $(MQ_IMAGE_GOLANG_SDK) -f incubating/mq-golang-sdk/Dockerfile . | ||
| build-golang-sdk: docker-version build-sdk | ||
| $(info $(shell printf $(TITLE)"Build $(MQ_IMAGE_GOLANG_SDK)"$(END))) | ||
| @echo hello |
| $(info $(shell printf $(TITLE)"Build $(MQ_IMAGE_GOLANG_SDK)"$(END))) | ||
| @echo hello | ||
| $(DOCKER) build --build-arg BASE_IMAGE=$(MQ_IMAGE_SDK) -t $(MQ_IMAGE_GOLANG_SDK) -f incubating/mq-golang-sdk/Dockerfile . | ||
| @echo goodbye |
parrobe
suggested changes
Mar 5, 2019
Makefile-UBUNTU
Outdated
| .PHONY: build-golang-sdk | ||
| build-golang-sdk: | ||
| $(DOCKER) build -t $(MQ_IMAGE_GOLANG_SDK) -f incubating/mq-golang-sdk/Dockerfile . | ||
| build-golang-sdk: docker-version build-sdk |
Member
There was a problem hiding this comment.
This one should also be called build-golang-sdk-ex
We will need a separate build-golang-sdk make target that does:
.PHONY: build-golang-sdk
build-golang-sdk: downloads/$(MQ_SDK_ARCHIVE) build-golang-sdk-ex
parrobe
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.