Skip to content

forward unencrypted 1756 to push notifications#607

Merged
ice-ares merged 2 commits into
masterfrom
feature/forward_1756_to_pn
Mar 19, 2026
Merged

forward unencrypted 1756 to push notifications#607
ice-ares merged 2 commits into
masterfrom
feature/forward_1756_to_pn

Conversation

@ice-cronus

Copy link
Copy Markdown
Contributor

No description provided.

@ice-cronus ice-cronus requested a review from a team as a code owner March 19, 2026 11:12
Comment thread push-notifications/notification_funds_transfer.go Outdated
Comment thread push-notifications/notification_funds_transfer.go
Comment thread push-notifications/notification_funds_transfer_test.go Outdated
Comment thread push-notifications/notification_funds_transfer_test.go
Comment thread push-notifications/pushnotifications.go
@ice-dionysos ice-dionysos requested a review from Copilot March 19, 2026 11:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds push-notification support for unencrypted Custom ION kind 1756 (CustomIONKindFundSendNotify) events by treating them as an anonymous payment received notification, and relaxes validation to accept these events without an on-behalf-of (b) tag.

Changes:

  • Update validation rules for CustomIONKindFundSendNotify to make model.CustomIONTagOnBehalfOf optional.
  • Add a new push notification type/translation and route kind 1756 events to a new handler (handleAnonymousFundSendEvent).
  • Bump indirect dependencies (github.com/lib/pq, github.com/sasha-s/go-deadlock).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
validation/validate.go Loosens required tags for kind 1756 to allow missing b tag.
push-notifications/pushnotifications.go Adds anonymous payment notification type/translation and dispatches kind 1756 to a new handler.
push-notifications/notification_funds_transfer.go Implements handler to generate notifications for kind 1756 using p as recipient.
push-notifications/notification_funds_transfer_test.go Adds unit test for the new handler logic.
go.mod Bumps indirect dependency versions.
go.sum Updates checksums for bumped dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread validation/validate.go
Comment thread push-notifications/pushnotifications.go Outdated
Comment thread push-notifications/pushnotifications.go
Comment thread push-notifications/notification_funds_transfer_test.go Outdated
@ice-ares ice-ares merged commit 87b863a into master Mar 19, 2026
32 checks passed
@ice-ares ice-ares deleted the feature/forward_1756_to_pn branch March 19, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants