forward unencrypted 1756 to push notifications#607
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds push-notification support for unencrypted Custom ION kind 1756 (CustomIONKindFundSendNotify) events by treating them as an anonymous payment received notification, and relaxes validation to accept these events without an on-behalf-of (b) tag.
Changes:
- Update validation rules for
CustomIONKindFundSendNotifyto makemodel.CustomIONTagOnBehalfOfoptional. - Add a new push notification type/translation and route kind 1756 events to a new handler (
handleAnonymousFundSendEvent). - Bump indirect dependencies (
github.com/lib/pq,github.com/sasha-s/go-deadlock).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
validation/validate.go |
Loosens required tags for kind 1756 to allow missing b tag. |
push-notifications/pushnotifications.go |
Adds anonymous payment notification type/translation and dispatches kind 1756 to a new handler. |
push-notifications/notification_funds_transfer.go |
Implements handler to generate notifications for kind 1756 using p as recipient. |
push-notifications/notification_funds_transfer_test.go |
Adds unit test for the new handler logic. |
go.mod |
Bumps indirect dependency versions. |
go.sum |
Updates checksums for bumped dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ice-dionysos
approved these changes
Mar 19, 2026
ice-ares
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.